From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
ak@linux.intel.com, stable@vger.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint
Date: Thu, 25 Jul 2019 09:54:50 +0200 [thread overview]
Message-ID: <20190725075450.GH31381@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190723200429.8180-1-kan.liang@linux.intel.com>
On Tue, Jul 23, 2019 at 01:04:29PM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Sampling SLOTS event and ref-cycles event in a group on Icelake gives
> EINVAL.
>
> SLOTS event is the event stands for the fixed counter 3, not fixed
> counter 2. Wrong mask was set to SLOTS event in
> intel_icl_pebs_event_constraints[].
>
> Fixes: 6017608936c1 ("perf/x86/intel: Add Icelake support")
> Reported-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Thanks!
next prev parent reply other threads:[~2019-07-25 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 20:04 [PATCH] perf/x86/intel: Fix SLOTS pebs event constraint kan.liang
2019-07-25 7:54 ` Peter Zijlstra [this message]
2019-07-25 16:05 ` [tip:perf/urgent] perf/x86/intel: Fix SLOTS PEBS " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725075450.GH31381@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox