public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default
Date: Thu, 25 Jul 2019 09:55:03 +0200	[thread overview]
Message-ID: <20190725075503.GA16693@kroah.com> (raw)
In-Reply-To: <20190718092522.17748-1-kai.heng.feng@canonical.com>

On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote:
> The procfs provides many useful information for debugging, but it may be
> too much for normal usage, routines like proc_get_sec_info() reports
> various security related information.
> 
> So disable it by defaultl.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/staging/rtl8723bs/include/autoconf.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h
> index 196aca3aed7b..8f4c1e734473 100644
> --- a/drivers/staging/rtl8723bs/include/autoconf.h
> +++ b/drivers/staging/rtl8723bs/include/autoconf.h
> @@ -57,9 +57,5 @@
>  #define DBG	0	/*  for ODM & BTCOEX debug */
>  #endif /*  !DEBUG */
>  
> -#ifdef CONFIG_PROC_FS
> -#define PROC_DEBUG
> -#endif

What?  Why?  If you are going to do this, then rip out all of the code
as well.

And are you _sure_ you want to do this?

thanks,

greg k-h

  reply	other threads:[~2019-07-25  7:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  9:25 [PATCH] staging: rtl8723bs: Disable procfs debugging by default Kai-Heng Feng
2019-07-25  7:55 ` Greg KH [this message]
2019-07-25 14:48   ` Kai-Heng Feng
2019-07-25 14:52     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725075503.GA16693@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox