From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97826C7618B for ; Thu, 25 Jul 2019 07:55:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 583FB217F4 for ; Thu, 25 Jul 2019 07:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564041309; bh=+tV5n5sf9wkieKz1ys/rYJZbU4avHfRqWAEuAygUAsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xtOo+UF7veJgGH32wW8HMRXWU0WzgoQacrIyJlNnnLv+9hPLINoDxYwZ8vj3lm7Jw CJQqvQhFJxJTDJclP/PfqNusb9b3TO0z2EEcCseZkL61lnHWLfV5gmyujpMlUydDaU 2FXdt3+bj/5KgXuUmG8/QNyiVuQWIUTXb52K464E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388636AbfGYHzH (ORCPT ); Thu, 25 Jul 2019 03:55:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388335AbfGYHzH (ORCPT ); Thu, 25 Jul 2019 03:55:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 031F5217F4; Thu, 25 Jul 2019 07:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564041306; bh=+tV5n5sf9wkieKz1ys/rYJZbU4avHfRqWAEuAygUAsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vEWb+a0imLFCZ742kKF0nm457xfdd0Y/iYu3AqTmEO9s5mdB808vWdCtpKr6TQQiT 5KJk9UGRUHLmuJNJk3wajuP0T5+voMa2iCRF612G27T1cv/teMYXUIX4Bveu5hATau euCAs+Mk6pOarNlfHG2u2b7/pP6+StS2+hy9HWUM= Date: Thu, 25 Jul 2019 09:55:03 +0200 From: Greg KH To: Kai-Heng Feng Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default Message-ID: <20190725075503.GA16693@kroah.com> References: <20190718092522.17748-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718092522.17748-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote: > The procfs provides many useful information for debugging, but it may be > too much for normal usage, routines like proc_get_sec_info() reports > various security related information. > > So disable it by defaultl. > > Signed-off-by: Kai-Heng Feng > --- > drivers/staging/rtl8723bs/include/autoconf.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h > index 196aca3aed7b..8f4c1e734473 100644 > --- a/drivers/staging/rtl8723bs/include/autoconf.h > +++ b/drivers/staging/rtl8723bs/include/autoconf.h > @@ -57,9 +57,5 @@ > #define DBG 0 /* for ODM & BTCOEX debug */ > #endif /* !DEBUG */ > > -#ifdef CONFIG_PROC_FS > -#define PROC_DEBUG > -#endif What? Why? If you are going to do this, then rip out all of the code as well. And are you _sure_ you want to do this? thanks, greg k-h