From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408A3C7618B for ; Thu, 25 Jul 2019 09:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AE6E2190F for ; Thu, 25 Jul 2019 09:40:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390685AbfGYJk5 (ORCPT ); Thu, 25 Jul 2019 05:40:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56325 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387533AbfGYJk5 (ORCPT ); Thu, 25 Jul 2019 05:40:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C3F9830C62A4; Thu, 25 Jul 2019 09:40:56 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id 5084160BEC; Thu, 25 Jul 2019 09:40:53 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 25 Jul 2019 11:40:56 +0200 (CEST) Date: Thu, 25 Jul 2019 11:40:52 +0200 From: Oleg Nesterov To: Christian Brauner Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, ebiederm@xmission.com, keescook@chromium.org, joel@joelfernandes.org, tglx@linutronix.de, tj@kernel.org, dhowells@redhat.com, jannh@google.com, luto@kernel.org, akpm@linux-foundation.org, cyphar@cyphar.com, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, kernel-team@android.com Subject: Re: [RFC][PATCH 1/5] exit: kill struct waitid_info Message-ID: <20190725094051.GC4707@redhat.com> References: <20190724144651.28272-1-christian@brauner.io> <20190724144651.28272-2-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190724144651.28272-2-christian@brauner.io> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 25 Jul 2019 09:40:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24, Christian Brauner wrote: > > Note that this changes how struct siginfo is filled in for users of > waitid. Namely, copy_siginfo_to_user() will nullify the extra SI_EXPANSION_SIZE bytes + 2*sizeof(__ARCH_SI_CLOCK_T) from _sigchld (waitid doesn't report utime/stime in siginfo). Looks correct... even the compat case, but please double-check copy_siginfo_to_user32/siginfo_layout. Looks like both SIL_KILL and SIL_CHLD cases are fine in that this patch can't add other user-visible changes, but I could easily miss something. > In case > anyone relies on the old behavior we can just revert we won't need to rever the whole patch, we can just replace copy_siginfo_to_user() with copy_to_user(offsetof(si_utime)). I see you are going to update the changelog and resend, feel free to add my reviewed-by. Oleg.