From: Christoph Hellwig <hch@infradead.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Christoph Hellwig <hch@infradead.org>,
John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Brian Starkey <Brian.Starkey@arm.com>,
Vincent Donnefort <Vincent.Donnefort@arm.com>,
Sudipto Paul <Sudipto.Paul@arm.com>,
Xu YiPing <xuyiping@hisilicon.com>,
"Chenfeng (puck)" <puck.chen@hisilicon.com>,
butao <butao@hisilicon.com>,
"Xiaqing (A)" <saberlily.xia@hisilicon.com>,
Yudongbin <yudongbin@hisilicon.com>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps
Date: Thu, 25 Jul 2019 07:04:48 -0700 [thread overview]
Message-ID: <20190725140448.GA25010@infradead.org> (raw)
In-Reply-To: <0eae0024-1fdf-bd06-a8ff-1a41f0af3c69@ti.com>
On Thu, Jul 25, 2019 at 09:31:50AM -0400, Andrew F. Davis wrote:
> But that's just it, dma-buf does not assume buffers are backed by normal
> kernel managed memory, it is up to the buffer exporter where and when to
> allocate the memory. The memory backed by this SRAM buffer does not have
> the normal struct page backing. So moving the map, sync, etc functions
> to common code would fail for this and many other heap types. This was a
> major problem with Ion that prompted this new design.
The code clearly shows it has page backing, e.g. this:
+ sg_set_page(table->sgl, pfn_to_page(PFN_DOWN(buffer->paddr)), buffer->len, 0);
and the fact that it (and the dma-buf API) uses scatterlists, which
requires pages.
next prev parent reply other threads:[~2019-07-25 14:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 19:49 [PATCH v6 0/5] DMA-BUF Heaps (destaging ION) John Stultz
2019-06-24 19:49 ` [PATCH v6 1/5] dma-buf: Add dma-buf heaps framework John Stultz
2019-06-24 19:49 ` [PATCH v6 2/5] dma-buf: heaps: Add heap helpers John Stultz
2019-07-18 10:06 ` Christoph Hellwig
2019-07-23 4:09 ` John Stultz
2019-07-23 20:09 ` Rob Clark
2019-07-24 6:55 ` Christoph Hellwig
2019-07-24 15:20 ` Andrew F. Davis
2019-07-25 12:41 ` Christoph Hellwig
2019-07-25 15:23 ` Rob Clark
2019-07-24 6:58 ` Christoph Hellwig
2019-06-24 19:49 ` [PATCH v6 3/5] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz
2019-06-24 19:49 ` [PATCH v6 4/5] dma-buf: heaps: Add CMA " John Stultz
2019-07-18 10:08 ` Christoph Hellwig
2019-07-23 5:04 ` John Stultz
2019-07-24 6:59 ` Christoph Hellwig
2019-07-24 8:08 ` Benjamin Gaignard
2019-07-25 12:45 ` Christoph Hellwig
2019-07-24 11:38 ` Laura Abbott
2019-07-25 12:48 ` Christoph Hellwig
2019-07-25 13:47 ` Andrew F. Davis
2019-07-25 14:05 ` Christoph Hellwig
2019-07-24 15:46 ` Andrew F. Davis
2019-07-25 12:50 ` Christoph Hellwig
2019-07-25 13:31 ` Andrew F. Davis
2019-07-25 14:04 ` Christoph Hellwig [this message]
2019-07-25 14:10 ` Andrew F. Davis
2019-07-25 14:11 ` Christoph Hellwig
2019-07-25 14:25 ` Andrew F. Davis
2019-07-25 14:30 ` Christoph Hellwig
2019-07-25 14:51 ` Andrew F. Davis
2019-07-24 18:46 ` John Stultz
2019-07-25 12:52 ` Christoph Hellwig
2019-07-25 13:20 ` Benjamin Gaignard
2019-07-25 14:33 ` Christoph Hellwig
2019-07-25 14:46 ` Benjamin Gaignard
2019-06-24 19:49 ` [PATCH v6 5/5] kselftests: Add dma-heap test John Stultz
2019-07-01 21:45 ` [PATCH v6 0/5] DMA-BUF Heaps (destaging ION) Laura Abbott
2019-07-01 21:55 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725140448.GA25010@infradead.org \
--to=hch@infradead.org \
--cc=Brian.Starkey@arm.com \
--cc=Sudipto.Paul@arm.com \
--cc=Vincent.Donnefort@arm.com \
--cc=afd@ti.com \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=butao@hisilicon.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=puck.chen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox