From: Kees Cook <keescook@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org,
gustavo@embeddedor.com, torvalds@linux-foundation.org,
acme@kernel.org, kan.liang@linux.intel.com, namhyung@kernel.org,
jolsa@redhat.com, linux-kernel@vger.kernel.org,
alexander.shishkin@linux.intel.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf/x86/intel: Mark expected switch fall-throughs
Date: Thu, 25 Jul 2019 16:28:31 -0700 [thread overview]
Message-ID: <201907251627.5DA61CB@keescook> (raw)
In-Reply-To: <ad5ec66830b502d68e6d3c814706b52490418f0f.camel@perches.com>
On Thu, Jul 25, 2019 at 04:18:56PM -0700, Joe Perches wrote:
> On Thu, 2019-07-25 at 19:35 +0200, Peter Zijlstra wrote:
> > Seriously though; I detest these patches and we really, as in _really_
> > should have done that attribute thing.
>
> At least it'll be fairly easy to convert to something
> sensible later.
>
> Variants of the equivalent of:
>
> s@/* fallthrough */@fallthrough;@
>
> with some trivial whitespace reformatting will read
> _much_ better.
>
> It's pretty scriptable.
Yup; that's been my perspective. First let's finish markings (so so
close right now), then we can do the next phase.
--
Kees Cook
prev parent reply other threads:[~2019-07-25 23:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 16:19 [PATCH] perf/x86/intel: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-06-24 19:31 ` Peter Zijlstra
2019-06-24 19:45 ` Joe Perches
2019-06-24 20:37 ` Peter Zijlstra
2019-06-24 20:53 ` Gustavo A. R. Silva
2019-06-24 20:57 ` Joe Perches
2019-06-25 7:20 ` Peter Zijlstra
2019-06-24 22:28 ` Miguel Ojeda
2019-06-25 7:18 ` Peter Zijlstra
2019-06-25 12:47 ` Miguel Ojeda
2019-06-25 18:15 ` Nick Desaulniers
2019-06-25 22:29 ` Joe Perches
2019-06-25 22:57 ` Nick Desaulniers
2019-06-25 23:25 ` Joe Perches
2019-06-26 8:49 ` Peter Zijlstra
2019-06-26 22:14 ` Nick Desaulniers
2019-06-27 7:12 ` Peter Zijlstra
2019-06-28 13:31 ` Peter Zijlstra
2019-06-28 18:44 ` Nick Desaulniers
2019-06-29 7:10 ` Peter Zijlstra
2019-06-25 17:12 ` Kees Cook
2019-06-25 18:05 ` Nathan Chancellor
2019-06-25 19:53 ` Thomas Gleixner
2019-06-25 20:27 ` Nathan Chancellor
2019-06-25 20:37 ` Nick Desaulniers
2019-06-25 21:47 ` Thomas Gleixner
2019-06-26 5:10 ` Nathan Chancellor
2019-06-26 15:18 ` Thomas Gleixner
2019-06-26 19:00 ` Nathan Chancellor
2019-06-26 19:46 ` Thomas Gleixner
2019-06-26 20:03 ` Nathan Chancellor
2019-06-26 9:24 ` Peter Zijlstra
2019-06-26 9:55 ` Peter Zijlstra
2019-06-26 22:23 ` Nick Desaulniers
2019-06-27 7:35 ` Peter Zijlstra
2019-06-26 10:43 ` Peter Zijlstra
2019-06-26 22:15 ` Nick Desaulniers
2019-06-27 7:16 ` Peter Zijlstra
2019-06-26 16:30 ` Peter Zijlstra
2019-06-26 22:33 ` Nick Desaulniers
2019-06-26 23:11 ` Thomas Gleixner
2019-06-27 7:11 ` Peter Zijlstra
2019-06-25 23:46 ` Arnaldo Carvalho de Melo
2019-06-26 5:14 ` Nathan Chancellor
2019-06-25 20:09 ` Kees Cook
2019-06-26 8:06 ` Peter Zijlstra
2019-06-25 7:15 ` Peter Zijlstra
2019-07-25 16:27 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
2019-07-25 17:06 ` Borislav Petkov
2019-07-25 17:35 ` Peter Zijlstra
2019-07-25 23:18 ` Joe Perches
2019-07-25 23:28 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907251627.5DA61CB@keescook \
--to=keescook@chromium.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox