From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A896C76190 for ; Fri, 26 Jul 2019 00:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D527922BF5 for ; Fri, 26 Jul 2019 00:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564102537; bh=o4hVED1DnXPhi52FO0wtBGwbvoqHLkWraSNdRFbEhmA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=RrYEqEaHN3NKTtSgb9ftBePwp2KCe6Qu1OddUE/LOsOHVDnwleV9pL8q5hQceTxeZ 8+jW4ovy0tJen9cr5JM5wdLpqr7iwPyZbIP9xIbzm12x/Ji/EeiChUih7SW2K4emzT lZQfYQ5EaaXmWGCldBNrMM/fV4qLcDzh4B+1fERY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbfGZAzg (ORCPT ); Thu, 25 Jul 2019 20:55:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:49872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfGZAzg (ORCPT ); Thu, 25 Jul 2019 20:55:36 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC8ED2238C; Fri, 26 Jul 2019 00:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564102535; bh=o4hVED1DnXPhi52FO0wtBGwbvoqHLkWraSNdRFbEhmA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L5uUd3GhpWzXG8NZ5VAfPLAogGQnqmrSDtJ2WoGzo4kODsjexGjl2plEX8UF4CwuW oU0gaoBumTXP+a5Fx+/RYg+bzmTeV7Qn9p0BT20Auw6fp70moUvLzgdHDbXgB4eoWy x3mw2X6mVGMx2Db5jEYPWqqxyerg3w7sEzNMLtn4= Date: Thu, 25 Jul 2019 17:55:33 -0700 From: Andrew Morton To: Kees Cook Cc: Alexandre Ghiti , Albert Ou , Catalin Marinas , Palmer Dabbelt , Will Deacon , Russell King , Ralf Baechle , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Burton , Alexander Viro , James Hogan , linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Luis Chamberlain Subject: Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version Message-Id: <20190725175533.f9fcc5139a9575560be7f679@linux-foundation.org> In-Reply-To: <201907251259.09E0101@keescook> References: <20190724055850.6232-1-alex@ghiti.fr> <20190724055850.6232-12-alex@ghiti.fr> <1ba4061a-c026-3b9e-cd91-3ed3a26fce1b@ghiti.fr> <201907251259.09E0101@keescook> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jul 2019 13:00:33 -0700 Kees Cook wrote: > > I have just noticed that this patch is wrong, do you want me to send > > another version of the entire series or is the following diff enough ? > > This mistake gets fixed anyway in patch 13/14 when it gets merged with the > > generic version. > > While I can't speak for Andrew, I'd say, since you've got Paul and > Luis's Acks to add now, I'd say go ahead and respin with the fix and the > Acks added. Yes please. After attending to Paul's questions on [14/14].