From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, quentin.perret@arm.com,
dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
pauld@redhat.com
Subject: Re: [PATCH 2/5] sched/fair: rename sum_nr_running to sum_h_nr_running
Date: Fri, 26 Jul 2019 07:47:45 +0530 [thread overview]
Message-ID: <20190726021745.GA7168@linux.vnet.ibm.com> (raw)
In-Reply-To: <1563523105-24673-3-git-send-email-vincent.guittot@linaro.org>
* Vincent Guittot <vincent.guittot@linaro.org> [2019-07-19 09:58:22]:
> sum_nr_running will track rq->nr_running task and sum_h_nr_running
> will track cfs->h_nr_running so we can use both to detect when other
> scheduling class are running and preempt CFS.
>
> There is no functional changes.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>
> ld_moved = 0;
> - if (busiest->nr_running > 1) {
> + if (busiest->cfs.h_nr_running > 1) {
We should be looking for nr_running here.
There could be only one cfs task but that may not be the current running
task, so it could be a good one to be picked for load balancing.
No?
> /*
> * Attempt to move tasks. If find_busiest_group has found
> * an imbalance but busiest->nr_running <= 1, the group is
> --
> 2.7.4
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2019-07-26 2:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 7:58 [PATCH 0/5] sched/fair: rework the CFS load balance Vincent Guittot
2019-07-19 7:58 ` [PATCH 1/5] sched/fair: clean up asym packing Vincent Guittot
2019-07-19 7:58 ` [PATCH 2/5] sched/fair: rename sum_nr_running to sum_h_nr_running Vincent Guittot
2019-07-19 12:51 ` Peter Zijlstra
2019-07-19 13:44 ` Vincent Guittot
2019-07-26 2:17 ` Srikar Dronamraju [this message]
2019-07-26 8:41 ` Vincent Guittot
2019-07-19 7:58 ` [PATCH 3/5] sched/fair: rework load_balance Vincent Guittot
2019-07-19 12:52 ` Peter Zijlstra
2019-07-19 13:46 ` Vincent Guittot
2019-07-19 12:54 ` Peter Zijlstra
2019-07-19 14:02 ` Vincent Guittot
2019-07-20 11:31 ` Peter Zijlstra
2019-07-19 13:06 ` Peter Zijlstra
2019-07-19 13:57 ` Vincent Guittot
2019-07-19 13:12 ` Peter Zijlstra
2019-07-19 14:13 ` Vincent Guittot
2019-07-19 13:22 ` Peter Zijlstra
2019-07-19 13:55 ` Vincent Guittot
2019-07-25 17:17 ` Valentin Schneider
2019-07-26 9:01 ` Vincent Guittot
2019-07-26 10:41 ` Valentin Schneider
2019-07-26 12:30 ` Vincent Guittot
2019-07-26 14:01 ` Valentin Schneider
2019-07-26 14:47 ` Vincent Guittot
2019-07-29 14:28 ` Valentin Schneider
2019-07-26 13:58 ` Srikar Dronamraju
2019-07-26 14:09 ` Valentin Schneider
2019-07-26 14:42 ` Vincent Guittot
2019-07-31 13:43 ` Srikar Dronamraju
2019-07-31 15:37 ` Vincent Guittot
2019-07-19 7:58 ` [PATCH 4/5] sched/fair: use load instead of runnable load Vincent Guittot
2019-07-19 7:58 ` [PATCH 5/5] sched/fair: evenly spread tasks when not overloaded Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726021745.GA7168@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox