From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D01BC76194 for ; Fri, 26 Jul 2019 02:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 442C0218B8 for ; Fri, 26 Jul 2019 02:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564108499; bh=acS6gRdr5t9i8wF+vujKiRrobtSNVj75fhnDKU6Yk14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aQtaWNXBKQq20T97nlmmWncf0+5MNFuQznqacu4Bc5sLGOf+4y+iVrg3r7QpRdD2j YuirZEODRUPlDm7jrtE9/YkrxsWwdsmYGDK0CfargnGaCwQNxoZgiRKgr9KGDGFqML au38TnnTmAMfrXF+V6xMtyVe0Xhro3brjL2Uc7hE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbfGZCe6 (ORCPT ); Thu, 25 Jul 2019 22:34:58 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46657 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfGZCe5 (ORCPT ); Thu, 25 Jul 2019 22:34:57 -0400 Received: by mail-pg1-f195.google.com with SMTP id k189so4942782pgk.13; Thu, 25 Jul 2019 19:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kQxMbqrsX/nZiD0N6XPZDIM95WzOo92zapucPy1vlUg=; b=oKcEphqrcIJTXgzvD1uIGdr1uqZO2gHbJqUCYNEjScVnAblxZ7V2fe3YaOhp91mxei HMBTDS5xNe4zP8el69NOJvVwqVrbeZ4vhgV39daqg1CBlxo1/Y0l1fJlXb2u0POuHO+G +fR8O/S29Hirw56Er6PMRq7F+Vh3GI18riHLeQYpDi6lRimdRcOAePdbgZFqMWzIeJRZ wfLljhwWF8vsCNEVuFI9iu9LiKanPYdZ0cOZ7vhxfgQ7CnngyxpbiaKc8mM2UEo7piE/ CEtQMq6PjMVOCWeKRpdJPWERXx4gZj0BLLz1IUhQV2CVQ7ZIL+/i8gkgUlPDYMRdHKHm a5+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kQxMbqrsX/nZiD0N6XPZDIM95WzOo92zapucPy1vlUg=; b=RKkME6Twf8QisiXx8XOZTzCM344Y0c0jA/4UrIZfEiFXOYb2UAJanbpidDwH8ETTB5 T74uq4j3i5RSbvbkx1/030dR+LUUadKPw9fUoQzjLaZ/FPtP/lf6Ji9Wii7WdBkU/Sv3 cxFeB+HrCFs5KF7eHemw/NtqMUE2AOtMydB5lO6qAE1EjtfY9zrBqsj6iN0u9I+oGqlW qpJZTDMuQkiY2frNQQL05lxNfq8V646yUzNTU/6kle8n1siu3EnkUvvVHlI56RXgjF+i xa2mdG08XsOOx23buS1XDKa3i1dze3U5t8ScDrZRnnXLTRc4LXB6MxhGRBSgH2f879XB QSbg== X-Gm-Message-State: APjAAAVkGfGxODxpveOrH7B+neyK4h6k4sTfmgG8t74seN0UV5RlfXwP lqA5/iAPD1eXIMOnsD9Qv7k= X-Google-Smtp-Source: APXvYqwCBy1Zc5tBK+qCsIuV/IuM/t64Rz0ADnQpNhj+o/kGXbRTjM5yaRilbKPxid2BEuggsNOknw== X-Received: by 2002:a63:3805:: with SMTP id f5mr55887841pga.272.1564108496625; Thu, 25 Jul 2019 19:34:56 -0700 (PDT) Received: from bbox-2.seo.corp.google.com ([2401:fa00:d:0:98f1:8b3d:1f37:3e8]) by smtp.gmail.com with ESMTPSA id l31sm88958450pgm.63.2019.07.25.19.34.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 19:34:55 -0700 (PDT) From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , linux-api@vger.kernel.org, Michal Hocko , Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Daniel Colascione , Shakeel Butt , Sonny Rao , oleksandr@redhat.com, hdanton@sina.com, lizeb@google.com, Dave Hansen , "Kirill A . Shutemov" , Minchan Kim Subject: [PATCH v7 2/5] mm: change PAGEREF_RECLAIM_CLEAN with PAGE_REFRECLAIM Date: Fri, 26 Jul 2019 11:34:32 +0900 Message-Id: <20190726023435.214162-3-minchan@kernel.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190726023435.214162-1-minchan@kernel.org> References: <20190726023435.214162-1-minchan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The local variable references in shrink_page_list is PAGEREF_RECLAIM_CLEAN as default. It is for preventing to reclaim dirty pages when CMA try to migrate pages. Strictly speaking, we don't need it because CMA didn't allow to write out by .may_writepage = 0 in reclaim_clean_pages_from_list. Moreover, it has a problem to prevent anonymous pages's swap out even though force_reclaim = true in shrink_page_list on upcoming patch. So this patch makes references's default value to PAGEREF_RECLAIM and rename force_reclaim with ignore_references to make it more clear. This is a preparatory work for next patch. * RFCv1 * use ignore_referecnes as parameter name - hannes Acked-by: Michal Hocko Acked-by: Johannes Weiner Signed-off-by: Minchan Kim --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 82e1e229eef21..436577236dd3e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1124,7 +1124,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, struct scan_control *sc, enum ttu_flags ttu_flags, struct reclaim_stat *stat, - bool force_reclaim) + bool ignore_references) { LIST_HEAD(ret_pages); LIST_HEAD(free_pages); @@ -1138,7 +1138,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, struct address_space *mapping; struct page *page; int may_enter_fs; - enum page_references references = PAGEREF_RECLAIM_CLEAN; + enum page_references references = PAGEREF_RECLAIM; bool dirty, writeback; unsigned int nr_pages; @@ -1269,7 +1269,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, } } - if (!force_reclaim) + if (!ignore_references) references = page_check_references(page, sc); switch (references) { -- 2.22.0.709.g102302147b-goog