From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
ebiederm@xmission.com, keescook@chromium.org,
joel@joelfernandes.org, tglx@linutronix.de, tj@kernel.org,
dhowells@redhat.com, jannh@google.com, luto@kernel.org,
akpm@linux-foundation.org, cyphar@cyphar.com,
torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
kernel-team@android.com
Subject: Re: [OFFLIST] [PATCH v1 0/2] pidfd: waiting on processes through pidfds
Date: Fri, 26 Jul 2019 12:02:53 +0200 [thread overview]
Message-ID: <20190726100252.GB16112@redhat.com> (raw)
In-Reply-To: <20190726093934.13557-1-christian@brauner.io>
Hi Christian,
just fyi, can't read this patch till Monday
On 07/26, Christian Brauner wrote:
> Hey everyone,
>
> /* v1 */
> This adds the ability to wait on processes using pidfds. This is one of
> the few missing pieces to make it possible to manage processes using
> only pidfds.
>
> Please note the following major changes (More details can be found in
> the individual commit changelogs.):
> - Add the new type P_PIDFD to waitid() instead of a new dedicated
> pidfd_wait() syscall.
> This is the same approach we discussed a few months ago and still
> prefer over adding a dedicated syscall.
> - Adapt the tests to the new type P_PIDFD for waitid().
> - Remove struct waitid_info patch.
> This will be sent out as a separate patch.
> - Remove CLONE_WAIT_PID patch.
> This will be sent out as a separate patch.
>
> The core patch for waitid is pleasantly small. The largest change is
> caused by adding proper tests for waitid(P_PIDFD).
>
> /* v0 */
> Link: https://lore.kernel.org/lkml/20190724144651.28272-1-christian@brauner.io
>
> Thanks!
> Christian
>
> Christian Brauner (2):
> pidfd: add P_PIDFD to waitid()
> pidfd: add pidfd_wait tests
>
> include/linux/pid.h | 4 +
> include/uapi/linux/wait.h | 1 +
> kernel/exit.c | 25 ++-
> kernel/fork.c | 8 +
> kernel/signal.c | 7 +-
> tools/testing/selftests/pidfd/pidfd.h | 25 +++
> tools/testing/selftests/pidfd/pidfd_test.c | 14 --
> tools/testing/selftests/pidfd/pidfd_wait.c | 245 +++++++++++++++++++++
> 8 files changed, 311 insertions(+), 18 deletions(-)
> create mode 100644 tools/testing/selftests/pidfd/pidfd_wait.c
>
> --
> 2.22.0
>
prev parent reply other threads:[~2019-07-26 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 9:39 [PATCH v1 0/2] pidfd: waiting on processes through pidfds Christian Brauner
2019-07-26 9:39 ` [PATCH v1 1/2] pidfd: add P_PIDFD to waitid() Christian Brauner
2019-07-26 21:26 ` Linus Torvalds
2019-07-26 21:30 ` Christian Brauner
2019-07-26 9:39 ` [PATCH v1 2/2] pidfd: add pidfd_wait tests Christian Brauner
2019-07-26 10:02 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726100252.GB16112@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox