From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Qian Cai <cai@lca.pw>, Thomas Gleixner <tglx@linutronix.de>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.9 17/30] x86/apic: Silence -Wtype-limits compiler warnings
Date: Fri, 26 Jul 2019 09:44:19 -0400 [thread overview]
Message-ID: <20190726134432.12993-17-sashal@kernel.org> (raw)
In-Reply-To: <20190726134432.12993-1-sashal@kernel.org>
From: Qian Cai <cai@lca.pw>
[ Upstream commit ec6335586953b0df32f83ef696002063090c7aef ]
There are many compiler warnings like this,
In file included from ./arch/x86/include/asm/smp.h:13,
from ./arch/x86/include/asm/mmzone_64.h:11,
from ./arch/x86/include/asm/mmzone.h:5,
from ./include/linux/mmzone.h:969,
from ./include/linux/gfp.h:6,
from ./include/linux/mm.h:10,
from arch/x86/kernel/apic/io_apic.c:34:
arch/x86/kernel/apic/io_apic.c: In function 'check_timer':
./arch/x86/include/asm/apic.h:37:11: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
if ((v) <= apic_verbosity) \
^~
arch/x86/kernel/apic/io_apic.c:2160:2: note: in expansion of macro
'apic_printk'
apic_printk(APIC_QUIET, KERN_INFO "..TIMER: vector=0x%02X "
^~~~~~~~~~~
./arch/x86/include/asm/apic.h:37:11: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
if ((v) <= apic_verbosity) \
^~
arch/x86/kernel/apic/io_apic.c:2207:4: note: in expansion of macro
'apic_printk'
apic_printk(APIC_QUIET, KERN_ERR "..MP-BIOS bug: "
^~~~~~~~~~~
APIC_QUIET is 0, so silence them by making apic_verbosity type int.
Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/1562621805-24789-1-git-send-email-cai@lca.pw
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/x86/include/asm/apic.h | 2 +-
arch/x86/kernel/apic/apic.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index 2188b5af8167..f39fd349cef6 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -50,7 +50,7 @@ static inline void generic_apic_probe(void)
#ifdef CONFIG_X86_LOCAL_APIC
-extern unsigned int apic_verbosity;
+extern int apic_verbosity;
extern int local_apic_timer_c2_ok;
extern int disable_apic;
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 4f2af1ee09cb..cc9a6f680225 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -183,7 +183,7 @@ int first_system_vector = FIRST_SYSTEM_VECTOR;
/*
* Debug level, exported for io_apic.c
*/
-unsigned int apic_verbosity;
+int apic_verbosity;
int pic_mode;
--
2.20.1
next prev parent reply other threads:[~2019-07-26 13:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 13:44 [PATCH AUTOSEL 4.9 01/30] ARM: riscpc: fix DMA Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 02/30] ARM: dts: rockchip: Make rk3288-veyron-minnie run at hs200 Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 03/30] ARM: dts: rockchip: Make rk3288-veyron-mickey's emmc work again Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 04/30] ARM: dts: rockchip: Mark that the rk3288 timer might stop in suspend Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 05/30] ftrace: Enable trampoline when rec count returns back to one Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 06/30] kernel/module.c: Only return -EEXIST for modules that have finished loading Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 07/30] MIPS: lantiq: Fix bitfield masking Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 08/30] dmaengine: rcar-dmac: Reject zero-length slave DMA requests Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 09/30] fs/adfs: super: fix use-after-free bug Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 10/30] btrfs: fix minimum number of chunk errors for DUP Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 11/30] ceph: fix improper use of smp_mb__before_atomic() Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 12/30] ceph: return -ERANGE if virtual xattr value didn't fit in buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 13/30] scsi: zfcp: fix GCC compiler warning emitted with -Wmaybe-uninitialized Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 14/30] ACPI: fix false-positive -Wuninitialized warning Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 15/30] ISDN: hfcsusb: checking idx of ep configuration Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 16/30] be2net: Signal that the device cannot transmit during reconfiguration Sasha Levin
2019-07-26 13:44 ` Sasha Levin [this message]
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 18/30] x86: math-emu: Hide clang warnings for 16-bit overflow Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 19/30] mm/cma.c: fail if fixed declaration can't be honored Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 20/30] coda: add error handling for fget Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 21/30] coda: fix build using bare-metal toolchain Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 22/30] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 23/30] drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 24/30] drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 25/30] ipc/mqueue.c: only perform resource calculation if user valid Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 26/30] floppy: fix div-by-zero in setup_format_params Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 27/30] floppy: fix out-of-bounds read in copy_buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 28/30] xen: let alloc_xenballooned_pages() fail if not enough memory free Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 29/30] x86/kvm: Don't call kvm_spurious_fault() from .fixup Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 30/30] x86, boot: Remove multiple copy of static function sanitize_boot_params() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726134432.12993-17-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox