From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Douglas Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>, Sasha Levin <sashal@kernel.org>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 04/30] ARM: dts: rockchip: Mark that the rk3288 timer might stop in suspend
Date: Fri, 26 Jul 2019 09:44:06 -0400 [thread overview]
Message-ID: <20190726134432.12993-4-sashal@kernel.org> (raw)
In-Reply-To: <20190726134432.12993-1-sashal@kernel.org>
From: Douglas Anderson <dianders@chromium.org>
[ Upstream commit 8ef1ba39a9fa53d2205e633bc9b21840a275908e ]
This is similar to commit e6186820a745 ("arm64: dts: rockchip: Arch
counter doesn't tick in system suspend"). Specifically on the rk3288
it can be seen that the timer stops ticking in suspend if we end up
running through the "osc_disable" path in rk3288_slp_mode_set(). In
that path the 24 MHz clock will turn off and the timer stops.
To test this, I ran this on a Chrome OS filesystem:
before=$(date); \
suspend_stress_test -c1 --suspend_min=30 --suspend_max=31; \
echo ${before}; date
...and I found that unless I plug in a device that requests USB wakeup
to be active that the two calls to "date" would show that fewer than
30 seconds passed.
NOTE: deep suspend (where the 24 MHz clock gets disabled) isn't
supported yet on upstream Linux so this was tested on a downstream
kernel.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm/boot/dts/rk3288.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 17ec2e2d7a60..30f1384f619b 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -210,6 +210,7 @@
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
clock-frequency = <24000000>;
+ arm,no-tick-in-suspend;
};
timer: timer@ff810000 {
--
2.20.1
next prev parent reply other threads:[~2019-07-26 13:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 13:44 [PATCH AUTOSEL 4.9 01/30] ARM: riscpc: fix DMA Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 02/30] ARM: dts: rockchip: Make rk3288-veyron-minnie run at hs200 Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 03/30] ARM: dts: rockchip: Make rk3288-veyron-mickey's emmc work again Sasha Levin
2019-07-26 13:44 ` Sasha Levin [this message]
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 05/30] ftrace: Enable trampoline when rec count returns back to one Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 06/30] kernel/module.c: Only return -EEXIST for modules that have finished loading Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 07/30] MIPS: lantiq: Fix bitfield masking Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 08/30] dmaengine: rcar-dmac: Reject zero-length slave DMA requests Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 09/30] fs/adfs: super: fix use-after-free bug Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 10/30] btrfs: fix minimum number of chunk errors for DUP Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 11/30] ceph: fix improper use of smp_mb__before_atomic() Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 12/30] ceph: return -ERANGE if virtual xattr value didn't fit in buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 13/30] scsi: zfcp: fix GCC compiler warning emitted with -Wmaybe-uninitialized Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 14/30] ACPI: fix false-positive -Wuninitialized warning Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 15/30] ISDN: hfcsusb: checking idx of ep configuration Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 16/30] be2net: Signal that the device cannot transmit during reconfiguration Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 17/30] x86/apic: Silence -Wtype-limits compiler warnings Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 18/30] x86: math-emu: Hide clang warnings for 16-bit overflow Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 19/30] mm/cma.c: fail if fixed declaration can't be honored Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 20/30] coda: add error handling for fget Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 21/30] coda: fix build using bare-metal toolchain Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 22/30] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 23/30] drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 24/30] drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 25/30] ipc/mqueue.c: only perform resource calculation if user valid Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 26/30] floppy: fix div-by-zero in setup_format_params Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 27/30] floppy: fix out-of-bounds read in copy_buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 28/30] xen: let alloc_xenballooned_pages() fail if not enough memory free Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 29/30] x86/kvm: Don't call kvm_spurious_fault() from .fixup Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 30/30] x86, boot: Remove multiple copy of static function sanitize_boot_params() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726134432.12993-4-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox