From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD17C7618B for ; Fri, 26 Jul 2019 13:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF06222CE8 for ; Fri, 26 Jul 2019 13:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148765; bh=KDln6zFomqC63mzorIXvEauG8u6B1BD1OXMjlYkRHkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IsaMc4pHR9vcZseQGdPSQDZ1RmY+OhjF/F0qZ8OqoUwjqdJIozFM1FOg8JJY1NS4e yTJSqIltGByWSBcWkC4MxW3aBbA98VlbP/HZGr76OWn8RzPQiGk702kwSsMH6ibWGK Nu+mRreKOMx/kvqgzkM+o2E1ytqyC810zk8RSOkQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388637AbfGZNqE (ORCPT ); Fri, 26 Jul 2019 09:46:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:55220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388606AbfGZNp6 (ORCPT ); Fri, 26 Jul 2019 09:45:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C423622CE7; Fri, 26 Jul 2019 13:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148757; bh=KDln6zFomqC63mzorIXvEauG8u6B1BD1OXMjlYkRHkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=heRb3E3K1Fa2acRm5HPxkFIosEpCLPlRji//sOIYW7sIrwFIzu4S9SH/IbzAoIcZR UjNYBe+3L0ZYSU0nFzFU8WbzKb1omGd1NL/Ph+UHFGdmdKAtugZNDo+j2FxayWq5hO fDl0+2n/Ln1RtSJoh4CVHWg8IerRnNNy9pv/KytY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhouyang Jia , Jan Harkes , Arnd Bergmann , Colin Ian King , Dan Carpenter , David Howells , Fabian Frederick , Mikko Rapeli , Sam Protsenko , Yann Droneaud , Andrew Morton , Linus Torvalds , Sasha Levin , codalist@coda.cs.cmu.edu Subject: [PATCH AUTOSEL 4.4 16/23] coda: add error handling for fget Date: Fri, 26 Jul 2019 09:45:15 -0400 Message-Id: <20190726134522.13308-16-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190726134522.13308-1-sashal@kernel.org> References: <20190726134522.13308-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhouyang Jia [ Upstream commit 02551c23bcd85f0c68a8259c7b953d49d44f86af ] When fget fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling fget. Link: http://lkml.kernel.org/r/2514ec03df9c33b86e56748513267a80dd8004d9.1558117389.git.jaharkes@cs.cmu.edu Signed-off-by: Zhouyang Jia Signed-off-by: Jan Harkes Cc: Arnd Bergmann Cc: Colin Ian King Cc: Dan Carpenter Cc: David Howells Cc: Fabian Frederick Cc: Mikko Rapeli Cc: Sam Protsenko Cc: Yann Droneaud Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/coda/psdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index 822629126e89..ff9b5cf8ff01 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -187,8 +187,11 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf, if (req->uc_opcode == CODA_OPEN_BY_FD) { struct coda_open_by_fd_out *outp = (struct coda_open_by_fd_out *)req->uc_data; - if (!outp->oh.result) + if (!outp->oh.result) { outp->fh = fget(outp->fd); + if (!outp->fh) + return -EBADF; + } } wake_up(&req->uc_sleep); -- 2.20.1