From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8A9C433FF for ; Sun, 28 Jul 2019 09:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 775B72075C for ; Sun, 28 Jul 2019 09:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZV53OTCs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726087AbfG1J5e (ORCPT ); Sun, 28 Jul 2019 05:57:34 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:46672 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfG1J5d (ORCPT ); Sun, 28 Jul 2019 05:57:33 -0400 Received: by mail-lj1-f196.google.com with SMTP id v24so55693767ljg.13; Sun, 28 Jul 2019 02:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I5U5P2OB+CW1lAAzC/g4JOE6432qGwFP+/JSwm0jSHU=; b=ZV53OTCsHDfSi2msA8fBNToBiGv1qSMCKgBQXDYU2lDS7+Vh64l0Pb6wOlXEw+vUT5 BrQdMuTWRPTsPW9wJ0fUQINwtKQjCoc1c1RqPp5JAz8SmrW/rBha8mnJF7LR1GERrUaj LjesFwNlFmzF84GiwhpjettdBknui1n0kO2MLU+Pc6SsbafRJ7ApvOMJWe8kWYFTdI+Y hNoTTnVK5r9Wr1aXZ9tiPSGv8QzT6eiCNYW/EN+iJxYX0YL2hhnUYbqDWsMd+T84+4Gi sQ94QOp1j2tk3Wq36Uonm35FoGLlhHtqwNgvSFIP4KQWRJkQpeHazVQYN1crYcniSP/J o7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I5U5P2OB+CW1lAAzC/g4JOE6432qGwFP+/JSwm0jSHU=; b=EzzNnF7J2CIxGuapku4kwbt3M5nAsr1d7cdMuAAxqXCnuJHdR1R1NLlFCE/9gm502d tnQX6QjfGFB7xEYc+MI6VoIJaC/CNLSLrOIUP1+IBR1XDGPAYBahOSLZB2WFjo0sbdyW iwa3fLNZ0kTuX23LY3BY7iluBORseHvwkbRXkXbDBah5162SeJIb5a86R0X+mfCdRBMc IndeOYA0qKccZ2mnxhYA8tEMhXcFGpcC36H+QczVYA4S2eo4P2muHBJyEoC7QyE4P3iA 468GbfXTiFk50LQ9Br4LG77NlR4S1jBg4GrfZRqIQ6P6ySePJNfPttUE3VbMKTZsqjLZ SBLQ== X-Gm-Message-State: APjAAAX3xC6fwKr74lRf/1/bQ4p7rDtU206dGWs1f9PJvE3J+jxC7xOo naNCSg3OqPLw7aFUA5Jweh0= X-Google-Smtp-Source: APXvYqwhw6OvM5th7He13Ewrm1ZQ2dCdDBT/HVP2qOAnliTHa6FW6BpkBP/nC5rQ9AHjO0hV9V2/2Q== X-Received: by 2002:a2e:9753:: with SMTP id f19mr54145925ljj.113.1564307850821; Sun, 28 Jul 2019 02:57:30 -0700 (PDT) Received: from localhost ([178.155.13.240]) by smtp.gmail.com with ESMTPSA id n187sm9919522lfa.30.2019.07.28.02.57.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jul 2019 02:57:29 -0700 (PDT) Date: Sun, 28 Jul 2019 12:57:26 +0300 From: Dmitry Torokhov To: Andy Shevchenko Cc: Maximilian Luz , Linux Kernel Mailing List , linux-input , Platform Driver , Hans de Goede , Chen Yu , Darren Hart , Andy Shevchenko , Benjamin Tissoires Subject: Re: [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Message-ID: <20190728095726.GA775@penguin> References: <20190720150511.95076-1-luzmaximilian@gmail.com> <20190720150511.95076-2-luzmaximilian@gmail.com> <20190727091541.GD795@penguin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 27, 2019 at 03:26:41PM +0300, Andy Shevchenko wrote: > On Sat, Jul 27, 2019 at 12:15 PM Dmitry Torokhov > wrote: > > > > On Thu, Jul 25, 2019 at 08:57:53PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 20, 2019 at 6:05 PM Maximilian Luz wrote: > > > > > > > > Do not use the surfacepro3_button driver on newer Microsoft Surface > > > > models, only use it on the Surface Pro 3 and 4. Newer models (5th, 6th > > > > and possibly future generations) use the same device as the Surface Pro > > > > 4 to represent their volume and power buttons (MSHW0040), but their > > > > actual implementation is significantly different. This patch ensures > > > > that the surfacepro3_button driver is only used on the Pro 3 and 4 > > > > models, allowing a different driver to bind on other models. > > > > > > > > > > Acked-by: Andy Shevchenko > > > > > > assuming it will go thru Input subsystem. > > > > I can take it, but I do not think it is dependent on the other change > > and thus can go through platform tree as well. > > Pkease, take it. I do not expect any changes to the driver this cycle. OK, applied, thank you. -- Dmitry