* [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through
@ 2019-07-29 0:02 Gustavo A. R. Silva
2019-07-29 5:38 ` Adrian Hunter
2019-08-02 15:16 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 0:02 UTC (permalink / raw)
To: Adrian Hunter, Ben Dooks, Jaehoon Chung, Ulf Hansson
Cc: linux-mmc, linux-kernel, Gustavo A. R. Silva, Stephen Rothwell,
Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->mmc->caps |= MMC_CAP_8_BIT_DATA;
drivers/mmc/host/sdhci-s3c.c:614:2: note: here
case 4:
^~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/mmc/host/sdhci-s3c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 8e4a8ba33f05..cefa0fb8cfde 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
switch (pdata->max_width) {
case 8:
host->mmc->caps |= MMC_CAP_8_BIT_DATA;
+ /* Fall through */
case 4:
host->mmc->caps |= MMC_CAP_4_BIT_DATA;
break;
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through
2019-07-29 0:02 [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-07-29 5:38 ` Adrian Hunter
2019-08-02 15:16 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2019-07-29 5:38 UTC (permalink / raw)
To: Gustavo A. R. Silva, Ben Dooks, Jaehoon Chung, Ulf Hansson
Cc: linux-mmc, linux-kernel, Stephen Rothwell, Kees Cook
On 29/07/19 3:02 AM, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
> drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->mmc->caps |= MMC_CAP_8_BIT_DATA;
> drivers/mmc/host/sdhci-s3c.c:614:2: note: here
> case 4:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 8e4a8ba33f05..cefa0fb8cfde 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
> switch (pdata->max_width) {
> case 8:
> host->mmc->caps |= MMC_CAP_8_BIT_DATA;
> + /* Fall through */
> case 4:
> host->mmc->caps |= MMC_CAP_4_BIT_DATA;
> break;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through
2019-07-29 0:02 [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 5:38 ` Adrian Hunter
@ 2019-08-02 15:16 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2019-08-02 15:16 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Adrian Hunter, Ben Dooks, Jaehoon Chung,
linux-mmc@vger.kernel.org, Linux Kernel Mailing List,
Stephen Rothwell, Kees Cook
On Mon, 29 Jul 2019 at 02:03, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
> drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=]
> host->mmc->caps |= MMC_CAP_8_BIT_DATA;
> drivers/mmc/host/sdhci-s3c.c:614:2: note: here
> case 4:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 8e4a8ba33f05..cefa0fb8cfde 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
> switch (pdata->max_width) {
> case 8:
> host->mmc->caps |= MMC_CAP_8_BIT_DATA;
> + /* Fall through */
> case 4:
> host->mmc->caps |= MMC_CAP_4_BIT_DATA;
> break;
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-02 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-29 0:02 [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 5:38 ` Adrian Hunter
2019-08-02 15:16 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox