From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5951DC7618F for ; Mon, 29 Jul 2019 00:11:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3214920693 for ; Mon, 29 Jul 2019 00:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="gH3oCbmk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbfG2ALx (ORCPT ); Sun, 28 Jul 2019 20:11:53 -0400 Received: from onstation.org ([52.200.56.107]:33482 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbfG2ALx (ORCPT ); Sun, 28 Jul 2019 20:11:53 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id A37F13E911; Mon, 29 Jul 2019 00:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1564359112; bh=fTbFvKTimvfSnY3qv6EFPf24BLGT92XXZetGoC+8T30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gH3oCbmkasua7ZqHWoXpzrYFMS2XYEalSeBlrnKp80q7IsWlxwJrL36R6Ld5jg50s daYNl/qq7EX0BKrVYHFY+/Fp/R1gvE9ZpmVo81puHzOrl+XC2k/Wzn1eWn0whVZ5fL yGCBXhyTfKb0Ov+hKYhXZmgd07Y43Mnf47CVRW6w= Date: Sun, 28 Jul 2019 20:11:51 -0400 From: Brian Masney To: Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Lina Iyer , Jon Hunter , Sowjanya Komatineni , Bitan Biswas , linux-tegra@vger.kernel.org, David Daney , Masahiro Yamada , Thierry Reding , Bjorn Andersson , Andy Gross , MSM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] gpio: allow customizing hierarchical IRQ chips Message-ID: <20190729001151.GA17127@onstation.org> References: <20190708110138.24657-1-masneyb@onstation.org> <20190708110138.24657-3-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 12:49:55AM +0200, Linus Walleij wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney wrote: > > +static void gpiochip_add_default_irq_domain_ops(struct irq_domain_ops *ops) > > +{ > > + if (!ops->activate) > > + ops->activate = gpiochip_irq_domain_activate; > > + > > + if (!ops->deactivate) > > + ops->deactivate = gpiochip_irq_domain_deactivate; > > + > > + if (!ops->translate) > > + ops->translate = gpiochip_hierarchy_irq_domain_translate; > > + > > + if (!ops->alloc) > > + ops->alloc = gpiochip_hierarchy_irq_domain_alloc; > > + > > + if (!ops->free) > > + ops->free = irq_domain_free_irqs_common; > > +} > > I'm fine with translate(), this seems to be what Lina needs too. > > But do we really need to make them all optional? activate() and > deactivate() will require the driver to lock the irq etc which is hairy. I can't think of a reason right now that we'd need to override the others. Since the structure was there, I made all of them optional to try to future proof this a little bit. It probably would be better to only make translate optional at this point. If needed, someone can submit a patch for one or more of the others with their use case. Brian