From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676A9C433FF for ; Mon, 29 Jul 2019 19:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3530B217D4 for ; Mon, 29 Jul 2019 19:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564429001; bh=bnNHVAa7cAU1dHs9mWMLdFPLJdL5nPw/dd6t3e9ifqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lqQmad5uSHSMGoNrr0FJxLAyy4XR1yoSqmEo2qCyh31Yv9N5DfC6aJuITrS6giKP6 2WNGRKJ6UqJadpjWWtdGtNRUDlf6DrCiP4+mwrnFNfR/OtFtTqZ7JiEKQVhWev8oX0 BX7fC8S0B8vYTM/PLIStlhkNzSDCysHJvcTARLnA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388239AbfG2Tgj (ORCPT ); Mon, 29 Jul 2019 15:36:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:51000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbfG2Tgg (ORCPT ); Mon, 29 Jul 2019 15:36:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 182D3217D9; Mon, 29 Jul 2019 19:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428995; bh=bnNHVAa7cAU1dHs9mWMLdFPLJdL5nPw/dd6t3e9ifqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gskMl46cvMCLuDukA5g3SNsywHb+/RXDhUfRWigtbg3tAs1Y8slESdm0gTklqGo7D Ua86g/Ny+8aFmxPBeEZ+6fM2h6FIOlAilEdKck4UvOWtkWSMDC+MQOhL/J8tb8d0iv 8W2RLYKsMCLtpq+vOTID9xvF2YLxaJqsyAne/hC8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Hancock , Lee Jones , Sasha Levin Subject: [PATCH 4.14 251/293] mfd: core: Set fwnode for created devices Date: Mon, 29 Jul 2019 21:22:22 +0200 Message-Id: <20190729190843.674050931@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c176c6d7e932662668bcaec2d763657096589d85 ] The logic for setting the of_node on devices created by mfd did not set the fwnode pointer to match, which caused fwnode-based APIs to malfunction on these devices since the fwnode pointer was null. Fix this. Signed-off-by: Robert Hancock Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index c57e407020f1..5c8ed2150c8b 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -179,6 +179,7 @@ static int mfd_add_device(struct device *parent, int id, for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; + pdev->dev.fwnode = &np->fwnode; break; } } -- 2.20.1