Re: [PATCH] s390/net: Mark expected switch fall-throughs

Julian Wiedmann
2019-08-05T07:25:33Z

On 30.07.19 02:17, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: s390):
>
> drivers/s390/net/ctcm_fsms.c: In function ‘ctcmpc_chx_attnbusy’:
> drivers/s390/net/ctcm_fsms.c:1703:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (grp->changed_side == 1) {
> ^
> drivers/s390/net/ctcm_fsms.c:1707:2: note: here
> case MPCG_STATE_XID0IOWAIX:
> ^~~~
>
> drivers/s390/net/ctcm_mpc.c: In function ‘ctc_mpc_alloc_channel’:
> drivers/s390/net/ctcm_mpc.c:358:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (callback)
> ^
> drivers/s390/net/ctcm_mpc.c:360:2: note: here
> case MPCG_STATE_XID0IOWAIT:
> ^~~~
>
> drivers/s390/net/ctcm_mpc.c: In function ‘mpc_action_timeout’:
> drivers/s390/net/ctcm_mpc.c:1469:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if ((fsm_getstate(rch->fsm) == CH_XID0_PENDING) &&
> ^
> drivers/s390/net/ctcm_mpc.c:1472:2: note: here
> default:
> ^~~~~~~
> drivers/s390/net/ctcm_mpc.c: In function ‘mpc_send_qllc_discontact’:
> drivers/s390/net/ctcm_mpc.c:2087:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (grp->estconnfunc) {
> ^
> drivers/s390/net/ctcm_mpc.c:2092:2: note: here
> case MPCG_STATE_FLOWC:
> ^~~~
>
> drivers/s390/net/qeth_l2_main.c: In function ‘qeth_l2_process_inbound_buffer’:
> drivers/s390/net/qeth_l2_main.c:328:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (IS_OSN(card)) {
> ^
> drivers/s390/net/qeth_l2_main.c:337:3: note: here
> default:
> ^~~~~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/s390/net/ctcm_fsms.c | 1 +
> drivers/s390/net/ctcm_mpc.c | 3 +++
> drivers/s390/net/qeth_l2_main.c | 2 +-
> 3 files changed, 5 insertions(+), 1 deletion(-)
>

Applied, thanks.