* [PATCH] ALSA: sparc: Mark expected switch fall-throughs
@ 2019-07-30 1:49 Gustavo A. R. Silva
2019-07-30 7:39 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-30 1:49 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel, Gustavo A. R. Silva, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: sparc64):
sound/sparc/dbri.c: In function ‘reverse_bytes’:
sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/sparc/dbri.c:583:2: note: here
case 16:
^~~~
sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/sparc/dbri.c:585:2: note: here
case 8:
^~~~
sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/sparc/dbri.c:587:2: note: here
case 4:
^~~~
sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/sparc/dbri.c:589:2: note: here
case 2:
^~~~
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/sparc/dbri.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 010113156239..6e065d44060e 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -580,12 +580,16 @@ static __u32 reverse_bytes(__u32 b, int len)
switch (len) {
case 32:
b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
+ /* fall through */
case 16:
b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
+ /* fall through */
case 8:
b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
+ /* fall through */
case 4:
b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
+ /* fall through */
case 2:
b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1);
case 1:
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs
2019-07-30 1:49 [PATCH] ALSA: sparc: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-30 7:39 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-07-30 7:39 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jaroslav Kysela, alsa-devel, Kees Cook, linux-kernel
On Tue, 30 Jul 2019 03:49:44 +0200,
Gustavo A. R. Silva wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: sparc64):
>
> sound/sparc/dbri.c: In function ‘reverse_bytes’:
> sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:583:2: note: here
> case 16:
> ^~~~
> sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:585:2: note: here
> case 8:
> ^~~~
> sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:587:2: note: here
> case 4:
> ^~~~
> sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
> b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
> ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:589:2: note: here
> case 2:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-30 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-30 1:49 [PATCH] ALSA: sparc: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-30 7:39 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox