From: Andrew Lunn <andrew@lunn.ch>
To: Tao Ren <taoren@fb.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Arun Parameswaran <arun.parameswaran@broadcom.com>,
Justin Chen <justinpopo6@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH net-next 1/2] net: phy: broadcom: set features explicitly for BCM54616S
Date: Tue, 30 Jul 2019 05:35:58 +0200 [thread overview]
Message-ID: <20190730033558.GB20628@lunn.ch> (raw)
In-Reply-To: <20190730002532.85509-1-taoren@fb.com>
On Mon, Jul 29, 2019 at 05:25:32PM -0700, Tao Ren wrote:
> BCM54616S feature "PHY_GBIT_FEATURES" was removed by commit dcdecdcfe1fc
> ("net: phy: switch drivers to use dynamic feature detection"). As dynamic
> feature detection doesn't work when BCM54616S is working in RGMII-Fiber
> mode (different sets of MII Control/Status registers being used), let's
> set "PHY_GBIT_FEATURES" for BCM54616S explicitly.
Hi Tao
What exactly does it get wrong?
Thanks
Andrew
next parent reply other threads:[~2019-07-30 3:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190730002532.85509-1-taoren@fb.com>
2019-07-30 3:35 ` Andrew Lunn [this message]
2019-07-30 5:05 ` [PATCH net-next 1/2] net: phy: broadcom: set features explicitly for BCM54616S Tao Ren
2019-07-30 6:00 ` Heiner Kallweit
2019-07-31 0:12 ` Tao Ren
2019-07-31 5:53 ` Heiner Kallweit
2019-07-31 6:00 ` Tao Ren
2019-08-01 5:20 ` Tao Ren
2019-08-02 1:29 ` Tao Ren
2019-08-04 8:40 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730033558.GB20628@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=arun.parameswaran@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox