From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A86B7C0650F for ; Tue, 30 Jul 2019 14:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ED34205C9 for ; Tue, 30 Jul 2019 14:26:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bobcopeland-com.20150623.gappssmtp.com header.i=@bobcopeland-com.20150623.gappssmtp.com header.b="b/YGcvOi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730909AbfG3O0C (ORCPT ); Tue, 30 Jul 2019 10:26:02 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:33035 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727425AbfG3O0C (ORCPT ); Tue, 30 Jul 2019 10:26:02 -0400 Received: by mail-io1-f66.google.com with SMTP id z3so9618380iog.0 for ; Tue, 30 Jul 2019 07:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bobcopeland-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+uMhQitWksYRbr8SuacmJdvNd2BY02Qb3I7uzgGDJds=; b=b/YGcvOirV6UwIvBt+Purp8CgdiD9jP1on0NcrCT5Qurn4xc367fLIjtoVqv/eZCjy mQEJA4mEJedVCjjuN+E2p6XuNrfXSnx8ddMP0aO8xjxeBQXKGZ5gIb/NgHOlHmMsk/Cy ioNicb4yOIp8oHSqgvAg9uedJ9fH8mMcR44Hkil3zhBOMGJUDCa5VTkvhKrIT9cI3XkU HUrm7tVU4Me8UnEepJ1rMVuS9A55Roa1Fe+/9Vmks95jlkCsAPvKSaxbb/55rNuH9ljc u5BzddUKGVIBQsRCmFmx67XmASOwHt/pk4WSLkTQFlCpfYye6oLgWhwoQYWKb+KX9G2C 9OGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+uMhQitWksYRbr8SuacmJdvNd2BY02Qb3I7uzgGDJds=; b=Irv3dfuY7Uxy1LD3WOU8VuZN/ZkUsQwii/+6j2s8WHsLw0CBGSga9pJ6p3CqHUlvEE lJA1lbDt/OyLZ1mhI6q7X/Q0h7n7n27wZltYM6VFa3eRlUx3vOA1sJ4ckGVsk3YyPvrQ IDZ/7PDsToH2gkIvTDqvXUbyaOzYHUbmgtry5bJGI2GGeCfN4OFVsLS4EfIS4mKC572h KPPMESS0nTuERuHYjGWjEpTaW7NsMo3LWSyzqDj5A9282S/I1A7nf/S745eyDpDr0wxt b85r+Eclfu/BQv/TxnnlfzXenvJrCd6b7nJtXMLJfDTF0QxrUqWyXvt9nAyfRZ9LCXr9 1DIQ== X-Gm-Message-State: APjAAAVsxN5V9Ut62qARVjMxQQsHXsTvv4De0FQIpSxRcbjGCn6xb6/C r9EMESOg+k3JGgMAPMjHukQ= X-Google-Smtp-Source: APXvYqxoRIqZ5FFC0f94kR6D3gBHlSMJJRHb790MkhvJ49D+YhJD96NUahg3+O5aFQ7RJbQtSmm2Zg== X-Received: by 2002:a6b:b9c2:: with SMTP id j185mr104642239iof.148.1564496761324; Tue, 30 Jul 2019 07:26:01 -0700 (PDT) Received: from hash ([2607:fea8:5ac0:1dd8:230:48ff:fe9d:9c89]) by smtp.gmail.com with ESMTPSA id c11sm36501054ioi.72.2019.07.30.07.26.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 07:26:00 -0700 (PDT) Received: from bob by hash with local (Exim 4.92) (envelope-from ) id 1hsT4h-0003Uj-Qd; Tue, 30 Jul 2019 10:25:59 -0400 Date: Tue, 30 Jul 2019 10:25:59 -0400 From: Bob Copeland To: Deepa Dinamani Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org, linux-karma-devel@lists.sourceforge.net Subject: Re: [PATCH 18/20] fs: omfs: Initialize filesystem timestamp ranges Message-ID: <20190730142559.GA4332@localhost> References: <20190730014924.2193-1-deepa.kernel@gmail.com> <20190730014924.2193-19-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730014924.2193-19-deepa.kernel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 06:49:22PM -0700, Deepa Dinamani wrote: > Fill in the appropriate limits to avoid inconsistencies > in the vfs cached inode times when timestamps are > outside the permitted range. > > Signed-off-by: Deepa Dinamani > Cc: me@bobcopeland.com > Cc: linux-karma-devel@lists.sourceforge.net > --- > fs/omfs/inode.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c > index 08226a835ec3..b76ec6b88ded 100644 > --- a/fs/omfs/inode.c > +++ b/fs/omfs/inode.c > @@ -478,6 +478,10 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent) > > sb->s_maxbytes = 0xffffffff; > > + sb->s_time_gran = NSEC_PER_MSEC; > + sb->s_time_min = 0; > + sb->s_time_max = U64_MAX / MSEC_PER_SEC; > + I honestly don't know if it should be s64 rather than u64, but considering that none of the devices with this filesystem ever exposed dates to users in the negative era, it should be fine. Acked-by: Bob Copeland -- Bob Copeland %% https://bobcopeland.com/