Re: [PATCH 14/22] ARM: dts: apalis-imx6: Add some example I2C devices

Fabio Estevam
2019-07-30T20:53:27Z

On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker <dev@pschenker.ch> wrote:

> &backlight {
> @@ -204,6 +228,77 @@
> */
> &i2c3 {
> status = "okay";
> +
> + adv7280: adv7280@21 {
> + compatible = "adv7280";
> + reg = <0x21>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu1_csi0 &pinctrl_cam_mclk>;
> + clocks = <&clks 200>;

Please replace this 200 with a proper clock label.

> + clock-names = "csi_mclk";
> + DOVDD-supply = <&reg_3p3v>;
> + AVDD-supply = <&reg_3p3v>;
> + DVDD-supply = <&reg_3p3v>;
> + PVDD-supply = <&reg_3p3v>;
> + csi_id = <0>;

This is not a valid property upstream.

It seems you just ported it from a downstream vendor kernel. Please
make sure you test with the dt-bindings from mainline.

> + mclk = <24000000>;
> + mclk_source = <1>;
> + status = "okay";
> + };
> +
> + /* Video ADC on Analog Camera Module */
> + adv7180: adv7180@21 {
> + compatible = "adv,adv7180";
> + reg = <0x21>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu1_csi0 &pinctrl_cam_mclk>;
> + clocks = <&clks 200>;

clock label, please.

> + clock-names = "csi_mclk";
> + DOVDD-supply = <&reg_3p3v>; /* 3.3v */
> + AVDD-supply = <&reg_3p3v>; /* 1.8v */
> + DVDD-supply = <&reg_3p3v>; /* 1.8v */
> + PVDD-supply = <&reg_3p3v>; /* 1.8v */
> + csi_id = <0>;

Same here

> + mclk = <24000000>;
> + mclk_source = <1>;
> + cvbs = <1>;
> + status = "disabled";
> + };
> +
> + max9526: max9526@20 {
> + compatible = "maxim,max9526";

This is not documented in mainline.