From: Sean Paul <sean@poorly.run>
To: YueHaibing <yuehaibing@huawei.com>
Cc: a.hajda@samsung.com, narmstrong@baylibre.com,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
seanpaul@chromium.org, heiko@sntech.de,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static
Date: Tue, 30 Jul 2019 13:07:38 -0400 [thread overview]
Message-ID: <20190730170738.GR104440@art_vandelay> (raw)
In-Reply-To: <20190730150057.57388-1-yuehaibing@huawei.com>
On Tue, Jul 30, 2019 at 11:00:57PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
> symbol 'analogix_dp_atomic_check' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for your patch, applied to drm-misc-next
Sean
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c82c7d5..f2f7f69 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
> }
>
>
> -int analogix_dp_atomic_check(struct drm_connector *connector,
> - struct drm_atomic_state *state)
> +static int analogix_dp_atomic_check(struct drm_connector *connector,
> + struct drm_atomic_state *state)
> {
> struct analogix_dp_device *dp = to_dp(connector);
> struct drm_connector_state *conn_state;
> --
> 2.7.4
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
prev parent reply other threads:[~2019-07-30 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 15:00 [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static YueHaibing
2019-07-30 17:07 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730170738.GR104440@art_vandelay \
--to=sean@poorly.run \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=seanpaul@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox