From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Luke Mujica <lukemujica@google.com>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, irogers@google.com,
eranian@google.com
Subject: Re: [PATCH] perf tools: Fix paths in include statements
Date: Tue, 30 Jul 2019 19:02:44 -0300 [thread overview]
Message-ID: <20190730220244.GB13361@kernel.org> (raw)
In-Reply-To: <20190719202253.220261-1-lukemujica@google.com>
Em Fri, Jul 19, 2019 at 01:22:53PM -0700, Luke Mujica escreveu:
> These paths point to the wrong location but still work because
> they get picked up by a -I flag that happens to direct to the correct
> file. Fix paths to lead to the actual file location without help from
> include flags.
Thanks, applied.
- Arnaldo
> Signed-off-by: Luke Mujica <lukemujica@google.com>
> ---
> tools/perf/arch/x86/util/kvm-stat.c | 4 ++--
> tools/perf/arch/x86/util/tsc.c | 6 +++---
> tools/perf/ui/helpline.c | 4 ++--
> tools/perf/ui/util.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/kvm-stat.c b/tools/perf/arch/x86/util/kvm-stat.c
> index 865a9762f22e..3f84403c0983 100644
> --- a/tools/perf/arch/x86/util/kvm-stat.c
> +++ b/tools/perf/arch/x86/util/kvm-stat.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <errno.h>
> -#include "../../util/kvm-stat.h"
> -#include "../../util/evsel.h"
> +#include "../../../util/kvm-stat.h"
> +#include "../../../util/evsel.h"
> #include <asm/svm.h>
> #include <asm/vmx.h>
> #include <asm/kvm.h>
> diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c
> index 950539f9a4f7..b1eb963b4a6e 100644
> --- a/tools/perf/arch/x86/util/tsc.c
> +++ b/tools/perf/arch/x86/util/tsc.c
> @@ -5,10 +5,10 @@
> #include <linux/stddef.h>
> #include <linux/perf_event.h>
>
> -#include "../../perf.h"
> +#include "../../../perf.h"
> #include <linux/types.h>
> -#include "../../util/debug.h"
> -#include "../../util/tsc.h"
> +#include "../../../util/debug.h"
> +#include "../../../util/tsc.h"
>
> int perf_read_tsc_conversion(const struct perf_event_mmap_page *pc,
> struct perf_tsc_conversion *tc)
> diff --git a/tools/perf/ui/helpline.c b/tools/perf/ui/helpline.c
> index b3c421429ed4..54bcd08df87e 100644
> --- a/tools/perf/ui/helpline.c
> +++ b/tools/perf/ui/helpline.c
> @@ -3,10 +3,10 @@
> #include <stdlib.h>
> #include <string.h>
>
> -#include "../debug.h"
> +#include "../util/debug.h"
> #include "helpline.h"
> #include "ui.h"
> -#include "../util.h"
> +#include "../util/util.h"
>
> char ui_helpline__current[512];
>
> diff --git a/tools/perf/ui/util.c b/tools/perf/ui/util.c
> index 63bf06e80ab9..9ed76e88a3e4 100644
> --- a/tools/perf/ui/util.c
> +++ b/tools/perf/ui/util.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #include "util.h"
> -#include "../debug.h"
> +#include "../util/debug.h"
>
>
> /*
> --
> 2.22.0.657.g960e92d24f-goog
--
- Arnaldo
next prev parent reply other threads:[~2019-07-30 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:22 [PATCH] perf tools: Fix paths in include statements Luke Mujica
2019-07-30 22:02 ` Arnaldo Carvalho de Melo [this message]
2019-08-15 9:19 ` [tip:perf/core] " tip-bot for Luke Mujica
-- strict thread matches above, loose matches on Subject: below --
2019-09-04 18:03 [PATCH] " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730220244.GB13361@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukemujica@google.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox