Re: [PATCH 4/6] arm64: dts: meson: sei510: Add minimal thermal zone

Neil Armstrong
2019-07-31T12:51:44Z

On 31/07/2019 14:14, Guillaume La Roque wrote:
> Add minimal thermal zone for DDR and CPU sensor
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index c7a87368850b..79ae514e238d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -33,6 +33,19 @@
> ethernet0 = &ethmac;
> };
>
> + thermal-zones {
> + soc_thermal {
> + polling-delay = <1000>;
> + polling-delay-ptripsassive = <100>;
> + thermal-sensors = <&cpu_temp 0>;

Seems the trips & cooling-maps are required as described in thermal.txt

For the soc_thermal zone it's esy to add a cooling map with the CPU
and cooling devices, but for the ddr_thermal, no idea if we can use the
CPUs within 2 cooling maps.

> + };

I would add a blank line between the zones, same for other files.

> + ddr_thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <100>;
> + thermal-sensors = <&ddr_temp 1>;
> + };
> + };
> +
> mono_dac: audio-codec-0 {
> compatible = "maxim,max98357a";
> #sound-dai-cells = <0>;
>