From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E6EC433FF for ; Wed, 31 Jul 2019 13:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36C37208E3 for ; Wed, 31 Jul 2019 13:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mBtfxVJW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388353AbfGaNqn (ORCPT ); Wed, 31 Jul 2019 09:46:43 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39001 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfGaNqm (ORCPT ); Wed, 31 Jul 2019 09:46:42 -0400 Received: by mail-pf1-f196.google.com with SMTP id f17so27914272pfn.6; Wed, 31 Jul 2019 06:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RYIopWVWcpN8sf8fn3WkAJoSebITP0aCuEJMOu9tUgo=; b=mBtfxVJW9PnBRKrB+uQBu32BkJW1DpQZK21apuGw6xkdbEf29gIZyyKKBNKsyyZm7T Ga8GPsjvU27IBLreAzB7a7JBLV3nGCHxyflt8fC1EwA6VwdBfXDpx/LNS41rsT+kQ8Iy zDWh6KkJWPSgwX3Ly9uADX1D/I/alhwGVlE8+MoaV6yis/Nx0NxQzD8Vasx70JUoBQLl gFz9JRgRRM3XSE5pOVNr5yNywlr8SvsPxy3La4y8RJkVKMTT6V7kF44Efel3pU/5L+0q wvIeY52cfH5D1V9uo9EVXnVAONdv7VVM9tng9EvnE42YXqooX738ht5TCdp+HtDTUlBG PDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RYIopWVWcpN8sf8fn3WkAJoSebITP0aCuEJMOu9tUgo=; b=is3VUeFa+ROoe1ueeviahILRpGoR2vt0g0fmSFXpjKlk7pyQO2hKunV0EzJ0Cn4jZH KO5Xhtdimwz8r8oj5JZoAT0d16sSx7n7MSVIHTF9zESJMjZzxQNpU3I8vBqbVVRAHyIo Nodqm2o0ie0JZ61W8raZ+wTtWArG3leOmnk0rsl3JsaEwbWdBMWJ1wwnfoBJA1UcMPbC pULnCulVKKosWPKe9oDozhic5MRbvTPJicRlLRlYfqF3aY4gHpGhzd39zRSEDHoQQHFo EVPveuC2N97DngTTi+dwvM6EwTBrqrOxmSbPC3NKg0faCaLWEsbgo1nFrzhgzNGv8bIS 3nFA== X-Gm-Message-State: APjAAAWlji+V5KrzSYI7u2VRYI9OU/QiP1/JCRrZdnSWYZmfj3Xgr8Ky EZAAeiIbq2Z/ixgXhHNT+FI= X-Google-Smtp-Source: APXvYqyJ632HMr8qTa4ZHPJ7wJMKy+mNNR1MgRTMRnjyHAyoRP9i2yT3EBmczwD7Wk7y+Y9PJWFOLg== X-Received: by 2002:a63:cb4f:: with SMTP id m15mr38212861pgi.100.1564580801437; Wed, 31 Jul 2019 06:46:41 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id u134sm66894809pfc.19.2019.07.31.06.46.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 06:46:40 -0700 (PDT) Date: Wed, 31 Jul 2019 06:46:38 -0700 From: Dmitry Torokhov To: Andy Shevchenko Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Richard Gong , "H. Peter Anvin" , Bartlomiej Zolnierkiewicz , Borislav Petkov , Darren Hart , Florian Fainelli , Ingo Molnar , Sudeep Holla , Thomas Gleixner , Tony Prisk , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 00/10] drivers, provide a way to add sysfs groups easily Message-ID: <20190731134638.GD147138@dtor-ws> References: <20190731124349.4474-1-gregkh@linuxfoundation.org> <20190731131045.GB147138@dtor-ws> <20190731133840.GN23480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731133840.GN23480@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 04:38:40PM +0300, Andy Shevchenko wrote: > On Wed, Jul 31, 2019 at 06:10:45AM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 31, 2019 at 02:43:39PM +0200, Greg Kroah-Hartman wrote: > > > This patch originally started out just as a way for platform drivers to > > > easily add a sysfs group in a race-free way, but thanks to Dmitry's > > > patch, this series now is for all drivers in the kernel (hey, a unified > > > driver model works!!!) > > > > > > I've only converted a few platform drivers here in this series to show > > > how it works, but other busses can be converted after the first patch > > > goes into the tree. > > > > > > Here's the original 00 message, for people to get an idea of what is > > > going on here: > > > > > > If a platform driver wants to add a sysfs group, it has to do so in a > > > racy way, adding it after the driver is bound. To resolve this issue, > > > have the platform driver core do this for the driver, making the > > > individual drivers logic smaller and simpler, and solving the race at > > > the same time. > > > > > > All of these patches depend on the first patch. I'll take the first one > > > through my driver-core tree, and any subsystem maintainer can either ack > > > their individul patch and I will be glad to also merge it, or they can > > > wait until after 5.4-rc1 when the core patch hits Linus's tree and then > > > take it, it's up to them. > > > > Maybe make an immutable branch off 5.2 with just patch 1/10 so that > > subsystems (and the driver core tree itself) could pull it in at their > > leisure into their "*-next" branches and did not have to wait till 5.4 > > or risk merge clashes? > > Isn't cherry-pick enough for one patch? With cherry-picking you run into potential merge conflicts if Greg changes more code in the same area. Plus, once everything is merged into Linus' tree, there will be N git commits adding the same thing. With immutable branch there is a single git commit, so merges are guaranteed to be clean, with no conflicts. Thanks. -- Dmitry