From: Mark Brown <broonie@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: of: Add of_node_put() before return in function
Date: Wed, 31 Jul 2019 20:08:59 +0100 [thread overview]
Message-ID: <20190731190859.GG4369@sirena.org.uk> (raw)
In-Reply-To: <8a1fa50a-3d1f-427d-c319-be2c6f5ccb6b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Wed, Jul 31, 2019 at 06:41:03PM +0530, Nishka Dasgupta wrote:
> My added code is dropping a reference to search, using of_node_put().
> I'm probably misunderstanding this at some point, but I thought search and
> child are two different nodes? Or am I completely misunderstanding what
> you're explaining?
Doh, sorry - missed that it's a different node (there's a lot of these
get mechanically sent).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-31 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:32 [PATCH] regulator: of: Add of_node_put() before return in function Nishka Dasgupta
2019-07-24 15:47 ` Mark Brown
2019-07-26 7:32 ` Nishka Dasgupta
2019-07-26 10:45 ` Mark Brown
2019-07-31 13:11 ` Nishka Dasgupta
2019-07-31 19:08 ` Mark Brown [this message]
2019-08-01 13:10 ` Applied "regulator: of: Add of_node_put() before return in function" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731190859.GG4369@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox