Re: [PATCH v2 1/4] bindings: rtc: add bindings for MT2712 RTC

Ran Bi
2019-08-23T06:35:44Z

Hi,

> > +Required properties:
> > +- compatible : Should be "mediatek,mt2712-rtc" : for MT2712 SoC
> > +- reg : Specifies base physical address and size of the registers;
> > +- interrupts : Should contain the interrupt for RTC alarm;
>
> No clocks for the RTC? What about CLK_TOP_RTC_SEL from the clk driver?
>
> Regards,
> Matthias
>

I suppose that we don't need clock control for mt2712 RTC. RTC clock is directly
come from 32K crystal and there is no control register to switch the clock. In mt2712,
CLK_TOP_RTC_SEL is prepared for other module even it called CLK_TOP_RTC_SEL.

Regards,
Ran

> > +
> > +Example:
> > +
> > +rtc: rtc@10011000 {
> > + compatible = "mediatek,mt2712-rtc";
> > + reg = <0 0x10011000 0 0x1000>;
> > + interrupts = <GIC_SPI 239 IRQ_TYPE_LEVEL_LOW>;
> > +};
> >