public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Raul Rangel <rrangel@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Tzung-Bi Shih <tzungbi@google.com>,
	bleung@chromium.org, groeck@chromium.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>,
	Dylan Reid <dgreid@google.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script
Date: Thu, 1 Aug 2019 08:50:50 -0600	[thread overview]
Message-ID: <20190801145050.GA154523@google.com> (raw)
In-Reply-To: <89aac768-b096-c51c-2ec7-5c135b089a31@collabora.com>

On Thu, Aug 01, 2019 at 03:30:53PM +0200, Enric Balletbo i Serra wrote:
 
> Got it. I don't think this is a "kernel" way to do it. Also, I don't see a big
> value on doing this.

Code generation sounds great, but it makes finding and looking at the
source file difficult unless you have a build. It also makes Go to
definition in my editor fail to find the symbols since they don't exist
in the source tree.
> 
> Note also that actually, we want:
> 
> - cros_ec_commands (kernel) sync with ec_commands (EC firmware)
> - cros_ec_commands (kernel) sync with cros_ec_trace (kernel)
> 
> Hopefully we will have all sync soon.

That would be great if you synced the commands from the EC firmware :)

Thanks

  reply	other threads:[~2019-08-01 14:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 13:47 [PATCH v4] platform/chrome: cros_ec_trace: update generating script Tzung-Bi Shih
2019-07-30 14:07 ` Tzung-Bi Shih
2019-08-01 10:59   ` Enric Balletbo i Serra
2019-08-01 13:04     ` Tzung-Bi Shih
2019-08-01 13:30       ` Enric Balletbo i Serra
2019-08-01 14:50         ` Raul Rangel [this message]
     [not found]           ` <CA+Px+wUzyFB6vRM91PTFkY_fBfp2xybegy34rbW_D9zzNX6-8Q@mail.gmail.com>
2019-08-29 13:42             ` Enric Balletbo i Serra
2019-08-29 13:51               ` Enric Balletbo Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801145050.GA154523@google.com \
    --to=rrangel@chromium.org \
    --cc=bleung@chromium.org \
    --cc=cychiang@google.com \
    --cc=dgreid@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox