From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3011C19759 for ; Thu, 1 Aug 2019 20:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F80F2084C for ; Thu, 1 Aug 2019 20:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564691133; bh=5RoZcFIWkJno+T2nNTwg4u2tni+S/MlSh0qACR6sNEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=A9loXiROhV2EI2EzREt4ofJDEs89gk1tai2KF5ZBwFSYA3wT7zVto1bHZBjdqAudk Mi5T/5LbupnP2RSxlBHAZ5a8b9NSrgO2FKgsUjTGEtUd/7JU579vb1wWYldo82A3IT QAjb7OYt21w12gqWXq8jlMoV/v6RyGb9Lv4yNqV8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbfHAUZc (ORCPT ); Thu, 1 Aug 2019 16:25:32 -0400 Received: from mga12.intel.com ([192.55.52.136]:17876 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfHAUZc (ORCPT ); Thu, 1 Aug 2019 16:25:32 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 13:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,335,1559545200"; d="scan'208";a="163729047" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2019 13:25:30 -0700 Date: Thu, 1 Aug 2019 14:22:51 -0600 From: Keith Busch To: Kai-Heng Feng Cc: "Rafael J. Wysocki" , Mario Limonciello , "Rafael J. Wysocki" , "Busch, Keith" , Christoph Hellwig , Sagi Grimberg , linux-nvme , Linux PM , Linux Kernel Mailing List , Rajat Jain Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems Message-ID: <20190801202251.GD15795@localhost.localdomain> References: <20190730144134.GA12844@localhost.localdomain> <100ba4aff1c6434a81e47774ab4acddc@AUSX13MPC105.AMER.DELL.COM> <8246360B-F7D9-42EB-94FC-82995A769E28@canonical.com> <20190730191934.GD13948@localhost.localdomain> <7d3e0b8ba1444194a153c93faa1cabb3@AUSX13MPC105.AMER.DELL.COM> <20190730213114.GK13948@localhost.localdomain> <20190731221956.GB15795@localhost.localdomain> <70D536BE-8DC7-4CA2-84A9-AFB067BA520E@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <70D536BE-8DC7-4CA2-84A9-AFB067BA520E@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 02:05:54AM -0700, Kai-Heng Feng wrote: > at 06:33, Rafael J. Wysocki wrote: > > On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote: > > > >> In which case we do need to reintroduce the HMB handling. > > > > Right. > > The patch alone doesn’t break HMB Toshiba NVMe I tested. But I think it’s > still safer to do proper HMB handling. Spec requires host request controller release HMB for D3cold. I suspect you're only getting to D3hot.