Re: [PATCH 4.9 033/223] perf test 6: Fix missing kvm module load for s390

Sasha Levin
2019-08-28T03:02:20Z

On Wed, Aug 28, 2019 at 01:12:44AM +0100, Ben Hutchings wrote:
>On Fri, 2019-08-02 at 11:34 +0200, Greg Kroah-Hartman wrote:
>> [ Upstream commit 53fe307dfd309e425b171f6272d64296a54f4dff ]
>
>This results in numerous compiler errors:
>
>tests/parse-events.c: In function 'kvm_s390_create_vm_valid':
>tests/parse-events.c:25:14: error: implicit declaration of function 'get_events_file' [-Werror=implicit-function-declaration]
> eventfile = get_events_file("kvm-s390");
> ^~~~~~~~~~~~~~~
>tests/parse-events.c:25:12: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> eventfile = get_events_file("kvm-s390");
> ^
>tests/parse-events.c:34:3: error: implicit declaration of function 'put_events_file' [-Werror=implicit-function-declaration]
> put_events_file(eventfile);
> ^~~~~~~~~~~~~~~
>tests/parse-events.c: At top level:
>tests/parse-events.c:1622:3: error: unknown field 'valid' specified in initializer
> .valid = kvm_s390_create_vm_valid,
> ^
>tests/parse-events.c:1622:12: error: excess elements in struct initializer [-Werror]
> .valid = kvm_s390_create_vm_valid,
> ^~~~~~~~~~~~~~~~~~~~~~~~
>tests/parse-events.c:1622:12: note: (near initialization for 'test__events[45]')
>
>It is using functions that were only added in Linux 4.18 so I think it
>should be reverted from the 4.4, 4.9, and 4.14 stable branches.

Sigh... I didn't think of adding cross compilation to the tools dir...

Thanks for this, now reverted for those branches.

--
Thanks,
Sasha