Re: [PATCH 1/2] crypto: ccp - Include DMA declarations explicitly

Gary R Hook
2019-08-06T16:45:43Z

On 8/2/19 6:20 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> ccp-dev.h uses dma_direction, which is defined in linux/dma-direction.h.
> Include that explicitly instead of relying on it being included via
> linux/pci.h, since ccp-dev.h requires nothing else from linux/pci.h.
>
> Similarly, ccp-dmaengine.c uses dma_get_mask(), which is defined in
> linux/dma-mapping.h, so include that explicitly since it requires nothing
> else from linux/pci.h.
>
> A future patch will remove the includes of linux/pci.h where it is not
> needed.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Acked-by: Gary R Hook <gary.hook@amd.com>

> ---
> drivers/crypto/ccp/ccp-dev.h | 1 +
> drivers/crypto/ccp/ccp-dmaengine.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/ccp/ccp-dev.h b/drivers/crypto/ccp/ccp-dev.h
> index 5e624920fd99..89aee0900a06 100644
> --- a/drivers/crypto/ccp/ccp-dev.h
> +++ b/drivers/crypto/ccp/ccp-dev.h
> @@ -17,6 +17,7 @@
> #include <linux/mutex.h>
> #include <linux/list.h>
> #include <linux/wait.h>
> +#include <linux/dma-direction.h>
> #include <linux/dmapool.h>
> #include <linux/hw_random.h>
> #include <linux/bitops.h>
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 7f22a45bbc11..f69d495873f0 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -9,6 +9,7 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> +#include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
> #include <linux/spinlock.h>
> #include <linux/mutex.h>
>