From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA72C0650F for ; Mon, 5 Aug 2019 16:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 816202147A for ; Mon, 5 Aug 2019 16:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m1WiCliO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729881AbfHEQyr (ORCPT ); Mon, 5 Aug 2019 12:54:47 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43707 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbfHEQyq (ORCPT ); Mon, 5 Aug 2019 12:54:46 -0400 Received: by mail-pf1-f195.google.com with SMTP id i189so39945331pfg.10 for ; Mon, 05 Aug 2019 09:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/bwTUWzlU15HZ3M3k+xzvMhkRem/kSeFzTKEw/QWQzc=; b=m1WiCliOfPATXps4NT1o26440TW93JM6y2lFBOkkl4UhZIoKRcjxYe4kOb96Wn9q6h fU92SqEpY3M+gulqXCmLPdu25VQ+vkJE7VEF5ROpGC+I6ihwkw8VdifqIJstsIdfw+4y F5XWa5mRp29t7u8AwCOBpgh3ewJl+iyP0XbLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/bwTUWzlU15HZ3M3k+xzvMhkRem/kSeFzTKEw/QWQzc=; b=dV+jU1PRm5MrmtaPdoNPkKWiIWsW6mGo95bJEFt9FJt50dPuu+cWLrdmbvAt+0013r oSdXQNypWdLHUNwt6Wi/o1WiSNNYZUF1k4jHpthO1itcede/gIkMzDuG0ZaQC2Dddb5B VbCOxvvrOk8W5Sr5QjB/UoD3EnVKya0qhxIxTSYGgbTTKVR/xMFp4g5E3BobdVtlsUn4 y89WsvI4tOmdhqdWjnWXubjFIHcJcG/jhd302BXCSD6ZQbCZZWGjOWb1pork6H5cVj8K 253jbIY6L+qkV7GWcdjzikUmxmuiVtcLnjlCYS3dhZ9mRQeLQWIyqFRXrh4RdUZXl8dg eFPg== X-Gm-Message-State: APjAAAW9/4xhRDhtNxMy9M2xWIm2lqaff/6Lkaw5aQxtcGpwyzGoSnpV nc3L9L4Ta3OVDJMOFAmGiiX7hA== X-Google-Smtp-Source: APXvYqw41x1+VlUG+f6ebMnURHbQ6wfQ/1Cp9FeJ/wPnnO1VWKcg8M+qfvWaeC6+kSoRPCXxLawOSw== X-Received: by 2002:aa7:82da:: with SMTP id f26mr74409261pfn.82.1565024086360; Mon, 05 Aug 2019 09:54:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p1sm90317138pff.74.2019.08.05.09.54.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Aug 2019 09:54:45 -0700 (PDT) Date: Mon, 5 Aug 2019 09:54:44 -0700 From: Kees Cook To: Borislav Petkov Cc: Thomas Garnier , kernel-hardening@lists.openwall.com, kristen@linux.intel.com, Herbert Xu , "David S. Miller" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 01/11] x86/crypto: Adapt assembly for PIE support Message-ID: <201908050952.BC1F7C3@keescook> References: <20190730191303.206365-1-thgarnie@chromium.org> <20190730191303.206365-2-thgarnie@chromium.org> <20190805163202.GD18785@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805163202.GD18785@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 06:32:02PM +0200, Borislav Petkov wrote: > On Tue, Jul 30, 2019 at 12:12:45PM -0700, Thomas Garnier wrote: > > Change the assembly code to use only relative references of symbols for the > > kernel to be PIE compatible. > > > > Position Independent Executable (PIE) support will allow to extend the > > KASLR randomization range below 0xffffffff80000000. > > I believe in previous reviews I asked about why this sentence is being > replicated in every commit message and now it is still in every commit > message except in 2/11. > > Why do you need it everywhere and not once in the 0th mail? I think there was some long-ago feedback from someone (Ingo?) about giving context for the patch so looking at one individually would let someone know that it was part of a larger series. This is a distant memory, though. Do you think it should just be dropped in each patch? -- Kees Cook