From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario.Limonciello@dell.com
Cc: yehezkelshb@gmail.com, linux-kernel@vger.kernel.org,
andreas.noever@gmail.com, michael.jamet@intel.com,
rjw@rjwysocki.net, lenb@kernel.org, lukas@wunner.de,
anthony.wong@canonical.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm
Date: Mon, 5 Aug 2019 16:15:07 +0300 [thread overview]
Message-ID: <20190805131507.GR2640@lahna.fi.intel.com> (raw)
In-Reply-To: <23cca57934d24eb6b897ebf00f852128@AUSX13MPC105.AMER.DELL.COM>
On Tue, Jul 09, 2019 at 03:11:15PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Sent: Friday, July 5, 2019 5:58 AM
> > To: Yehezkel Bernat
> > Cc: LKML; Andreas Noever; Michael Jamet; Rafael J . Wysocki; Len Brown; Lukas
> > Wunner; Limonciello, Mario; Anthony Wong; linux-acpi@vger.kernel.org
> > Subject: Re: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct
> > icm
> >
> >
> > [EXTERNAL EMAIL]
> >
> > On Fri, Jul 05, 2019 at 01:52:49PM +0300, Yehezkel Bernat wrote:
> > > > @@ -2054,6 +2059,7 @@ struct tb *icm_probe(struct tb_nhi *nhi)
> > > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_NHI:
> > > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_NHI:
> > > > icm->max_boot_acl = ICM_AR_PREBOOT_ACL_ENTRIES;
> > > > + icm->can_upgrade_nvm = true;
> > >
> > > Shouldn't this be also !x86_apple_machine just like AR?
> > > (For FR, we don't use ICM on Apple machines, as much as I remember, so it's fine
> > > to enable it there unconditionally for ICM code path.)
> >
> > Yes, good point. I'll fix it up.
>
> Another thought - does the TR or AR ID's setting can_upgrade_nvm to !x86_apple_machine
> show up in anything like a dock or is it only host controllers? If it's in docks, then it might be worth
> only blocking on apple if it's a host.
It affects only hosts so on Apple system you can't upgrade host NVM but
docks and other devices you can.
next prev parent reply other threads:[~2019-08-05 13:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 9:57 [PATCH 0/8] thunderbolt: Intel Ice Lake support Mika Westerberg
2019-07-05 9:57 ` [PATCH 1/8] thunderbolt: Correct path indices for PCIe tunnel Mika Westerberg
2019-07-05 9:57 ` [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm Mika Westerberg
2019-07-05 10:52 ` Yehezkel Bernat
2019-07-05 10:58 ` Mika Westerberg
2019-07-09 15:11 ` Mario.Limonciello
2019-08-05 13:15 ` Mika Westerberg [this message]
2019-07-05 9:57 ` [PATCH 3/8] thunderbolt: Use 32-bit writes when writing ring producer/consumer Mika Westerberg
2019-07-05 11:09 ` Yehezkel Bernat
2019-07-05 11:24 ` Mika Westerberg
2019-07-05 16:04 ` David Laight
2019-08-07 16:13 ` Mika Westerberg
2019-08-07 16:22 ` David Laight
2019-08-07 16:36 ` 'Mika Westerberg'
2019-08-07 16:41 ` David Laight
2019-08-08 9:57 ` 'Mika Westerberg'
2019-08-12 9:01 ` David Laight
2019-07-05 9:57 ` [PATCH 4/8] thunderbolt: Do not fail adding switch if some port is not implemented Mika Westerberg
2019-08-03 14:14 ` Lukas Wunner
2019-08-05 13:17 ` Mika Westerberg
2019-07-05 9:57 ` [PATCH 5/8] thunderbolt: Hide switch attributes that are not set Mika Westerberg
2019-07-05 9:57 ` [PATCH 6/8] thunderbolt: Expose active parts of NVM even if upgrade is not supported Mika Westerberg
2019-07-05 9:57 ` [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake Mika Westerberg
2019-07-05 14:44 ` Yehezkel Bernat
2019-07-05 14:51 ` Mika Westerberg
2019-07-05 15:02 ` Yehezkel Bernat
2019-08-04 18:25 ` Lukas Wunner
2019-08-05 14:16 ` Mika Westerberg
2019-07-05 9:58 ` [PATCH 8/8] ACPI / property: Add two new Thunderbolt property GUIDs to the list Mika Westerberg
2019-07-09 8:18 ` Rafael J. Wysocki
2019-07-05 10:33 ` [PATCH 0/8] thunderbolt: Intel Ice Lake support Mika Westerberg
2019-07-05 14:56 ` Yehezkel Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805131507.GR2640@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=andreas.noever@gmail.com \
--cc=anthony.wong@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=rjw@rjwysocki.net \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox