From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E8CC433FF for ; Mon, 5 Aug 2019 14:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 049F3214C6 for ; Mon, 5 Aug 2019 14:34:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="j/TctoPy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729182AbfHEOeO (ORCPT ); Mon, 5 Aug 2019 10:34:14 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36516 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbfHEOeO (ORCPT ); Mon, 5 Aug 2019 10:34:14 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x75EXing098472; Mon, 5 Aug 2019 14:34:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=R4AOBudPFLJRuw7DV0+iZCZVJBMP3lldxNCVm/9odU8=; b=j/TctoPyHJG97doeNoftHFJ8c9dl34ZGW1OkxxglGy2uIfZcdDqPoDPOcdUP4hDzz+JM MWTo0N9n9wKy2AQYAEz+bqzhsJoE5q+maLeT41Zx7jKoyB//XmOpLVsl1uL9Dcix06G0 FycN68UvUsQ8uHZak9kBajAu4OpgohE8SJrcB5RXT+42Xochdz7fLSVSUxNSycjvAinQ AXh3P+RTtgfq6sVk6VKpiv43BnZ6I+LinoknMhDDuaVGW6+a3LBYkVTvz4IZSwhClv45 hGVKP7FXCfoB1KK7dzTOpSYhxYXJfp+B4d0E8wY4Ths++NV2eSdvFi0okiGW/mXHMX9m bg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2u51ptqra4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 05 Aug 2019 14:34:10 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x75EWfoK090751; Mon, 5 Aug 2019 14:34:10 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2u4ycu3hp6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 05 Aug 2019 14:34:09 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x75EY7oB024183; Mon, 5 Aug 2019 14:34:08 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 05 Aug 2019 07:34:07 -0700 Date: Mon, 5 Aug 2019 17:33:56 +0300 From: Dan Carpenter To: Giridhar Prasath R Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix the following checkpatch warnings: Message-ID: <20190805143356.GC1974@kadam> References: <20190804234322.4410-1-cristianoprasath@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190804234322.4410-1-cristianoprasath@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9340 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=827 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908050162 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9340 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=889 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908050162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject isn't right and I don't really feel that the change makes the code more beautiful to look at. regards, dan carpenter