From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F888C0650F for ; Mon, 5 Aug 2019 15:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 184B8206C1 for ; Mon, 5 Aug 2019 15:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565017389; bh=+Xz3bwnFyaWyqY9a37gwwnBNAogellhkHzcb0xquKIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OsUPKqSYEFu2bkZ0Q8OlHFABBik1KnRFnpK/Pb69AMb+v//B70alt+36Ii69ZXBqu yc+rWc6USp4IPBY563qONstgA+5oPmpRmw1fiF9kXjn41doBq+zgAdYEeh0ycQugbb pGY1XyMoWkRaPtubbji1YqDNwrhgGe7KT5EvaIsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729021AbfHEPDI (ORCPT ); Mon, 5 Aug 2019 11:03:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:36544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728043AbfHEPDH (ORCPT ); Mon, 5 Aug 2019 11:03:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46BBA206C1; Mon, 5 Aug 2019 15:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565017386; bh=+Xz3bwnFyaWyqY9a37gwwnBNAogellhkHzcb0xquKIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=au5ozn6Us640CQSmT+gPP1wjfGcLKu+5AO3u44G76dCrxZWNyyj1JcwczmM6US+Dn IiWu9CBPX4J8YB54hKk0nqGlb9y9AuROg+Rzr1ViY2xle0v+U4k59UI9YGzet5c7YZ Uu9F7zgngDfMe+2b6iAurxNCW5MLhRAYDMZGoEO8= Date: Mon, 5 Aug 2019 17:03:04 +0200 From: Greg Kroah-Hartman To: Giridhar Prasath R Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433 line over 80 characters in multiple places Message-ID: <20190805150304.GA746@kroah.com> References: <20190805000248.4902-1-cristianoprasath@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805000248.4902-1-cristianoprasath@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 05:32:45AM +0530, Giridhar Prasath R wrote: > Fix the following checkpatch warnings: > > WARNING: line over 80 characters > FILE: drivers/staging/pi433/pi433_if.h > > Signed-off-by: Giridhar Prasath R > --- > drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h > index 9feb95c431cb..915bd96910c6 100644 > --- a/drivers/staging/pi433/pi433_if.h > +++ b/drivers/staging/pi433/pi433_if.h > @@ -117,9 +117,14 @@ struct pi433_rx_cfg { > > /* packet format */ > enum option_on_off enable_sync; > - enum option_on_off enable_length_byte; /* should be used in combination with sync, only */ > - enum address_filtering enable_address_filtering; /* operational with sync, only */ > - enum option_on_off enable_crc; /* only operational, if sync on and fixed length or length byte is used */ > + /* should be used in combination with sync, only */ > + enum option_on_off enable_length_byte; > + /* operational with sync, only */ > + enum address_filtering enable_address_filtering; > + /* only operational, > + * if sync on and fixed length or length byte is used > + */ > + enum option_on_off enable_crc; > > __u8 sync_length; > __u8 fixed_message_length; > @@ -132,10 +137,14 @@ struct pi433_rx_cfg { > > #define PI433_IOC_MAGIC 'r' > > -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) > -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) > +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ > +char[sizeof(struct pi433_tx_cfg)]) Ick, that does not look better :( We write code for humans first, compilers second. The original is fine, thanks. greg k-h