From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-kernel@vger.kernel.org, Paul Pawlowski <paul@mrarm.io>,
Jens Axboe <axboe@fb.com>, Minwoo Im <minwoo.im.dev@gmail.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers
Date: Mon, 5 Aug 2019 12:35:58 -0600 [thread overview]
Message-ID: <20190805183557.GA22859@localhost.localdomain> (raw)
In-Reply-To: <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me>
On Mon, Aug 05, 2019 at 11:27:54AM -0700, Sagi Grimberg wrote:
>
> > > Ping ? I had another look today and I don't feel like mucking around
> > > with all the AQ size logic, AEN magic tag etc... just for that sake of
> > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem
> > > to make much of a difference in practice anyway.
> > >
> > > But if you feel strongly about it, then I'll implement the "proper" way
> > > sometimes this week, adding a way to shrink the AQ down to something
> > > like 3 (one admin request, one async event (AEN), and the empty slot)
> > > by making a bunch of the constants involved variables instead.
> >
> > I don't feel too strongly about it. I think your patch is fine, so
> >
> > Acked-by: Keith Busch <keith.busch@intel.com>
>
> Should we pick this up for 5.3-rc?
Probably not. While I don't think this is a risky patch set, it's not
a bug fix for anything we introduced during the merge window. Christoph
also stated he wanted this to go in the 5.4 merge window.
next prev parent reply other threads:[~2019-08-05 18:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 5:31 [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers Benjamin Herrenschmidt
2019-07-19 5:45 ` Balbir Singh
2019-07-19 12:28 ` Christoph Hellwig
2019-07-19 13:51 ` Benjamin Herrenschmidt
2019-07-22 21:54 ` Benjamin Herrenschmidt
2019-07-23 1:36 ` Ming Lei
2019-07-30 15:30 ` Keith Busch
2019-07-30 20:15 ` Benjamin Herrenschmidt
2019-07-30 20:28 ` Benjamin Herrenschmidt
2019-08-05 6:49 ` Benjamin Herrenschmidt
2019-08-05 13:49 ` Keith Busch
2019-08-05 18:27 ` Sagi Grimberg
2019-08-05 18:35 ` Keith Busch [this message]
2019-08-05 19:07 ` Jens Axboe
2019-08-05 19:56 ` Sagi Grimberg
2019-08-05 20:07 ` Sagi Grimberg
2019-08-06 5:26 ` Benjamin Herrenschmidt
2019-08-06 5:26 ` Benjamin Herrenschmidt
2019-08-06 5:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805183557.GA22859@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=paul@mrarm.io \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox