From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A629CC433FF for ; Tue, 6 Aug 2019 10:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83BD120818 for ; Tue, 6 Aug 2019 10:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732552AbfHFKma (ORCPT ); Tue, 6 Aug 2019 06:42:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:15053 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730068AbfHFKma (ORCPT ); Tue, 6 Aug 2019 06:42:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 03:42:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="192636407" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 06 Aug 2019 03:42:01 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 06 Aug 2019 13:42:01 +0300 Date: Tue, 6 Aug 2019 13:42:01 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-kernel@vger.kernel.org, Lukas Wunner Subject: Re: [PATCH v1] thunderbolt: Switch to use device_property_count_uXX() Message-ID: <20190806104201.GN2548@lahna.fi.intel.com> References: <20190723192154.68114-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723192154.68114-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 10:21:54PM +0300, Andy Shevchenko wrote: > Use use device_property_count_uXX() directly, that makes code neater. > > Signed-off-by: Andy Shevchenko Applied, thanks! > --- > drivers/thunderbolt/eeprom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c > index 81e8ac4c5805..2366406e49ac 100644 > --- a/drivers/thunderbolt/eeprom.c > +++ b/drivers/thunderbolt/eeprom.c > @@ -414,7 +414,7 @@ static int tb_drom_copy_efi(struct tb_switch *sw, u16 *size) > struct device *dev = &sw->tb->nhi->pdev->dev; > int len, res; > > - len = device_property_read_u8_array(dev, "ThunderboltDROM", NULL, 0); > + len = device_property_count_u8(dev, "ThunderboltDROM"); > if (len < 0 || len < sizeof(struct tb_drom_header)) > return -EINVAL; > > -- > 2.20.1