Re: [PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing

Joel Fernandes
2019-08-07T20:44:54Z

On Wed, Aug 07, 2019 at 01:01:22PM -0700, Andrew Morton wrote:
> On Wed, 7 Aug 2019 06:00:13 -0400 Joel Fernandes <joel@joelfernandes.org> wrote:
>
> > > > 8 files changed, 376 insertions(+), 45 deletions(-)
> > >
> > > Quite a lot of new code unconditionally added to major architectures.
> > > Are we confident that everyone will want this feature?
> >
> > I did not follow, could you clarify more? All of this diff stat is not to
> > architecture code:
>
>
> My point is that the patchset adds a lot of new code with no way in
> which users can opt out. Almost everyone gets a fatter kernel - how
> many of those users will actually benefit from it?
>
> If "not many" then shouldn't we be making it Kconfigurable?

Almost all of this code is already configurable with
CONFIG_IDLE_PAGE_TRACKING. If you disable it, then all of this code gets
disabled.

Or are you referring to something else that needs to be made configurable?

> Are there userspace tools which present this info to users or which
> provide monitoring of some form? Do major distros ship those tools?
> Do people use them? etcetera.
>

Android's heapprofd is what I was working on which is already using it (patch
is not yet upstreamed). There is working set tracking which Sandeep (also
from Android) said he wants to use. Minchan plans to use this in combination
with ZRAM-based idle tracking. Mike Rappoport also showed some interest, but
I am not sure where/how he is using it. These are just some of the usecases I
am aware off. I am pretty sure more will come as well.

thanks,

- Joel