Re: [PATCH AUTOSEL 4.4 01/14] xtensa: fix build for cores with coprocessors

Max Filippov
2019-08-19T17:06:50Z

On Mon, Aug 19, 2019 at 9:53 AM Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
>
> On Tue, 2019-08-06 at 17:37 -0400, Sasha Levin wrote:
> > From: Max Filippov <jcmvbkbc@gmail.com>
> >
> > [ Upstream commit e3cacb73e626d885b8cf24103fed0ae26518e3c4 ]
> >
> > Assembly entry/return abstraction change didn't add asmmacro.h include
> > statement to coprocessor.S, resulting in references to undefined macros
> > abi_entry and abi_ret on cores that define XTENSA_HAVE_COPROCESSORS.
> > Fix that by including asm/asmmacro.h from the coprocessor.S.
> [...]
>
> This seems to be fixing commit d6d5f19e21d9 "xtensa: abstract 'entry'
> and 'retw' in assembly code" so it wouldn't be needed for any stable
> branches.

That's correct.

--
Thanks.
-- Max