From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A8CC433FF for ; Wed, 7 Aug 2019 10:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0463E21E6E for ; Wed, 7 Aug 2019 10:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565175095; bh=WxYKmhU/d5C298A+QtBpNasoo7mco0vHhZ0d36pXWmI=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=gMhVcEYtZxXp3OW/uLD5cvFJd8E1/I8vSwY+G/a5Qdtu/kQ4qGZ+vCvmHHhqTFrtQ sVWEEaU6Ec2CVduahHFw+9qbZAPzp/ic25Kn84MAIqLa9oFZuxwxv4YTy/QiG/WKkB TaCOAy554f4191NtTGDRO9KWfse/5+C8ofWrH/4o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729525AbfHGKvc (ORCPT ); Wed, 7 Aug 2019 06:51:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:55190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729160AbfHGKv3 (ORCPT ); Wed, 7 Aug 2019 06:51:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AC7E21E6E; Wed, 7 Aug 2019 10:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565175088; bh=WxYKmhU/d5C298A+QtBpNasoo7mco0vHhZ0d36pXWmI=; h=Date:From:To:Subject:References:In-Reply-To:From; b=S0RRfBTRawE6q8RXJDyAjSHYILuXDbyvegg0dkISG3juePwVznQWaSGWPC+Ga9en4 12hNxlMT7eLaennWRaH/xK2EyAw9Kc45Jpq+//XWvPanG7w8UgeB93w9Vjlj9vz5tt lFWjghhhY1rhRW03ghl1JK7ifWKZPcBRCOdDD7Fg= Date: Wed, 7 Aug 2019 12:51:26 +0200 From: Greg KH To: dsterba@suse.cz, Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Sterba , Filipe Manana , linux-btrfs@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.19 12/32] Btrfs: fix deadlock between fiemap and transaction commits Message-ID: <20190807105126.GA14880@kroah.com> References: <20190806213522.19859-1-sashal@kernel.org> <20190806213522.19859-12-sashal@kernel.org> <20190807094759.GQ28208@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807094759.GQ28208@suse.cz> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 11:47:59AM +0200, David Sterba wrote: > On Tue, Aug 06, 2019 at 05:35:00PM -0400, Sasha Levin wrote: > > From: Filipe Manana > > > > [ Upstream commit a6d155d2e363f26290ffd50591169cb96c2a609e ] > > > > Fixes: 03628cdbc64db6 ("Btrfs: do not start a transaction during fiemap") > > The commit is a regression fix during the 5.2 cycle, how it could end up > in a 4.19 stable candidate? > > $ git describe 03628cdbc64db6 > v5.1-rc7-201-g03628cdbc64d > > $ git describe --contains 03628cdbc64db6 > v5.2-rc1~163^2~26 > > And it does not belong to 5.2 either, git cherry-pick on top of 5.2 > fails. > > I think such sanity check can be done automatically so the patches don't > accidentally land in trees where don't belong. Commit 03628cdbc64d ("Btrfs: do not start a transaction during fiemap") was tagged for the stable trees, and ended up in the following releases: 4.14.121 4.19.45 5.0.18 5.1.4 5.2 so yes, it does need to go back to all of those locations if this patch really does fix the issue there. thanks, greg k-h