From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D00C433FF for ; Wed, 7 Aug 2019 14:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACE9121E6C for ; Wed, 7 Aug 2019 14:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="PJh2pZx1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388121AbfHGOHq (ORCPT ); Wed, 7 Aug 2019 10:07:46 -0400 Received: from onstation.org ([52.200.56.107]:42714 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbfHGOHq (ORCPT ); Wed, 7 Aug 2019 10:07:46 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id BA57E3E951; Wed, 7 Aug 2019 14:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1565186865; bh=6WKzOMIrRhn+HZ7Ye4fD0m71zD/5MBx+bsdK86Uuj2c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJh2pZx1sesHz3Pw1IeyqA+GVWbYfJ/w8c7srPHO3nDhOIha6mDNXfDJs6HHIfAjM CiXOvgEDhoMJYJEGRjJPE4brU1fDnmAqM60bKD9D20iVuIvBNLfFPQ3sn4nRUezk7d wQ6YdoznMAubLi/7Re6c8szg+FIep7LAAvM4XQtw= Date: Wed, 7 Aug 2019 10:07:44 -0400 From: Brian Masney To: Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Lina Iyer , Jon Hunter , Sowjanya Komatineni , Bitan Biswas , linux-tegra@vger.kernel.org, David Daney , Masahiro Yamada , Thierry Reding , Bjorn Andersson , Andy Gross , MSM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/4] gpio: hierarchical IRQ improvements Message-ID: <20190807140744.GA18224@onstation.org> References: <20190708110138.24657-1-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 03:41:05PM +0200, Linus Walleij wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney wrote: > > > This builds on top of Linus Walleij's existing patches that adds > > hierarchical IRQ support to the GPIO core [1] so that Qualcomm's > > spmi-gpio and ssbi-gpio can be converted to use these new helpers. > > > > Linus: Feel free to squash these into your existing patches if you'd > > like to use any of this code. Just give me some kind of mention in the > > commit description. > > > > [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.walleij@linaro.org/ > > > > Brian Masney (4): > > gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell > > functions > > gpio: allow customizing hierarchical IRQ chips > > gpio: use handler in gpio_irq_chip instead of handle_bad_irq > > qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core > > I solved things like this: > > - I kept patches 1 & 4 as-is > - I squashed patches 2 and 3 into the main patch with minor modifications. > - I added Co-developed-by: for your contributions > > Now I need to address Masahiro's comments on top and let's see if the > result looks acceptable! > Ooops had to squash patch 1 as well... All of this sounds good. I'll retest once you send out the updated series. Brian