Re: [PATCH 8/8] ACPI / property: Add two new Thunderbolt property GUIDs to the list

Rafael J. Wysocki
2019-07-09T08:18:57Z

On Fri, Jul 5, 2019 at 11:58 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Ice Lake Thunderbolt controller includes two new device property
> compatible properties that we need to be able to extract in the driver
> so add them to the growing array of GUIDs.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/acpi/property.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index da3ced297f19..07cbacbab861 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -39,6 +39,12 @@ static const guid_t prp_guids[] = {
> /* External facing port GUID: efcc06cc-73ac-4bc3-bff0-76143807c389 */
> GUID_INIT(0xefcc06cc, 0x73ac, 0x4bc3,
> 0xbf, 0xf0, 0x76, 0x14, 0x38, 0x07, 0xc3, 0x89),
> + /* TBT GUID for IMR_VALID: c44d002f-69f9-4e7d-a904-a7baabdf43f7 */

I'd prefer Thunderbolt to be spelled in full here (and below).

LGTM otherwise.

> + GUID_INIT(0xc44d002f, 0x69f9, 0x4e7d,
> + 0xa9, 0x04, 0xa7, 0xba, 0xab, 0xdf, 0x43, 0xf7),
> + /* TBT GUID for WAKE_SUPPORTED: 6c501103-c189-4296-ba72-9bf5a26ebe5d */
> + GUID_INIT(0x6c501103, 0xc189, 0x4296,
> + 0xba, 0x72, 0x9b, 0xf5, 0xa2, 0x6e, 0xbe, 0x5d),
> };
>
> /* ACPI _DSD data subnodes GUID: dbb8e3e6-5886-4ba6-8795-1319f52a966b */
> --
> 2.20.1
>