From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] drm: add gem ttm helpers
Date: Wed, 7 Aug 2019 23:08:53 +0200 [thread overview]
Message-ID: <20190807210853.GH7444@phenom.ffwll.local> (raw)
In-Reply-To: <20190807115133.gkr2svqlvq366mub@sirius.home.kraxel.org>
On Wed, Aug 07, 2019 at 01:51:33PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > > > I don't think so. drm_gem_dumb_map_offset() calls
> > > > > drm_gem_create_mmap_offset(), which I think is not correct for ttm
> > > > > objects because ttm_bo_init() handles vma_node initialization.
>
> > Ok I looked again, and your ttm version seems to exactly match
> > drm_gem_dumb_map_offset(),
>
> No. The difference outlined above is still there. See also v2 which
> adds an comment saying so.
Creating an mmap offset is idempotent. Otherwise the gem version would
already blow up real bad, since it's getting called multiple times by
userspace already.
So I still think ttm isn't special here, how did this blow up when you
tried?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-08-07 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190806133454.8254-1-kraxel@redhat.com>
2019-08-06 13:34 ` [PATCH 1/3] drm: add gem ttm helpers Gerd Hoffmann
2019-08-06 13:54 ` Daniel Vetter
2019-08-07 7:26 ` Gerd Hoffmann
2019-08-07 8:28 ` Daniel Vetter
2019-08-07 10:36 ` Gerd Hoffmann
2019-08-07 11:40 ` Daniel Vetter
2019-08-07 11:51 ` Gerd Hoffmann
2019-08-07 21:08 ` Daniel Vetter [this message]
2019-08-06 15:46 ` Sam Ravnborg
2019-08-06 15:51 ` Sam Ravnborg
2019-08-06 13:34 ` [PATCH 2/3] drm/vram: switch vram helpers to use the new " Gerd Hoffmann
2019-08-06 13:34 ` [PATCH 3/3] drm/qxl: switch qxl " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807210853.GH7444@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox