From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5165DC433FF for ; Thu, 8 Aug 2019 03:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B64F2186A for ; Thu, 8 Aug 2019 03:27:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730718AbfHHD1D (ORCPT ); Wed, 7 Aug 2019 23:27:03 -0400 Received: from mga04.intel.com ([192.55.52.120]:48657 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728019AbfHHD1C (ORCPT ); Wed, 7 Aug 2019 23:27:02 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 20:27:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="203426188" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 07 Aug 2019 20:27:01 -0700 Date: Thu, 8 Aug 2019 11:26:38 +0800 From: Wei Yang To: Michal Hocko Cc: Wei Yang , Vlastimil Babka , akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmap.c: refine data locality of find_vma_prev Message-ID: <20190808032638.GA28138@richard> Reply-To: Wei Yang References: <20190806081123.22334-1-richardw.yang@linux.intel.com> <3e57ba64-732b-d5be-1ad6-eecc731ef405@suse.cz> <20190807003109.GB24750@richard> <20190807075101.GN11812@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807075101.GN11812@dhcp22.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 09:51:01AM +0200, Michal Hocko wrote: >On Wed 07-08-19 08:31:09, Wei Yang wrote: >> On Tue, Aug 06, 2019 at 11:29:52AM +0200, Vlastimil Babka wrote: >> >On 8/6/19 10:11 AM, Wei Yang wrote: >> >> When addr is out of the range of the whole rb_tree, pprev will points to >> >> the biggest node. find_vma_prev gets is by going through the right most >> > >> >s/biggest/last/ ? or right-most? >> > >> >> node of the tree. >> >> >> >> Since only the last node is the one it is looking for, it is not >> >> necessary to assign pprev to those middle stage nodes. By assigning >> >> pprev to the last node directly, it tries to improve the function >> >> locality a little. >> > >> >In the end, it will always write to the cacheline of pprev. The caller has most >> >likely have it on stack, so it's already hot, and there's no other CPU stealing >> >it. So I don't understand where the improved locality comes from. The compiler >> >can also optimize the patched code so the assembly is identical to the previous >> >code, or vice versa. Did you check for differences? >> >> Vlastimil >> >> Thanks for your comment. >> >> I believe you get a point. I may not use the word locality. This patch tries >> to reduce some unnecessary assignment of pprev. >> >> Original code would assign the value on each node during iteration, this is >> what I want to reduce. > >Is there any measurable difference (on micro benchmarks or regular >workloads)? I wrote a test case to compare these two methods, but not find visible difference in run time. While I found we may leverage rb_last to refine the code a little. @@ -2270,12 +2270,9 @@ find_vma_prev(struct mm_struct *mm, unsigned long addr, if (vma) { *pprev = vma->vm_prev; } else { - struct rb_node *rb_node = mm->mm_rb.rb_node; - *pprev = NULL; - while (rb_node) { - *pprev = rb_entry(rb_node, struct vm_area_struct, vm_rb); - rb_node = rb_node->rb_right; - } + struct rb_node *rb_node = rb_last(&mm->mm_rb); + *pprev = !rb_node ? NULL : + rb_entry(rb_node, struct vm_area_struct, vm_rb); } return vma; Not sure this style would help a little in understanding the code? >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me