Re: [PATCH v2 2/2] virtio_ring: packed ring: fix virtqueue_detach_unused_buf

Pankaj Gupta
2019-08-08T12:44:59Z

> On Thu, Aug 08, 2019 at 08:28:46AM -0400, Pankaj Gupta wrote:
> >
> >
> > > > This patch makes packed ring code compatible with split ring in
> > > > function
> > > > 'virtqueue_detach_unused_buf_*'.
> > >
> > > What does that mean? What does this "fix"?
> >
> > Patch 1 frees the buffers When a port is unplugged from the virtio
> > console device. It does this with the help of
> > 'virtqueue_detach_unused_buf_split/packed'
> > function. For split ring case, corresponding function decrements avail ring
> > index.
> > For packed ring code, this functionality is not available, so this patch
> > adds the
> > required support and hence help to remove the unused buffer completely.
>
> Explain all of this in great detail in the changelog comment. What you
> have in there today does not make any sense.

Sure. Will try to put in more clear words.

Thanks,
Pankaj

>
> thanks,
>
> greg k-h
>