From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AC4C433FF for ; Thu, 8 Aug 2019 15:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9D1E2173E for ; Thu, 8 Aug 2019 15:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733190AbfHHPch (ORCPT ); Thu, 8 Aug 2019 11:32:37 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40508 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfHHPch (ORCPT ); Thu, 8 Aug 2019 11:32:37 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id D319028CAE4; Thu, 8 Aug 2019 16:32:35 +0100 (BST) Date: Thu, 8 Aug 2019 17:32:32 +0200 From: Boris Brezillon To: Tomer Maimon Cc: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, vigneshr@ti.com, bbrezillon@kernel.org, avifishman70@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver Message-ID: <20190808173232.4d79d698@collabora.com> In-Reply-To: <20190808131448.349161-3-tmaimon77@gmail.com> References: <20190808131448.349161-1-tmaimon77@gmail.com> <20190808131448.349161-3-tmaimon77@gmail.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Aug 2019 16:14:48 +0300 Tomer Maimon wrote: > + > +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = { > + .exec_op = npcm_fiu_exec_op, No npcm_supports_op()? That's suspicious, especially after looking at the npcm_fiu_exec_op() (and the functions called from there) where the requested ->buswidth seems to be completely ignored... > + .dirmap_create = npcm_fiu_dirmap_create, > + .dirmap_read = npcm_fiu_direct_read, > + .dirmap_write = npcm_fiu_direct_write, > +}; > +