From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C24AC0650F for ; Thu, 8 Aug 2019 19:48:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F62C21874 for ; Thu, 8 Aug 2019 19:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565293703; bh=4WUS76RX+FiZef2BNrBwnS2eID3LAJlXHfM9bsTyhPQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=y7H2SDZ/pS01POyoSsh8FDrparEBgfhy01cCyhbyqbKz2UKUsTTrVPvwSEGAW4oPc /H6xiSwk6pyDQOakY4AS15+DaDL1ht8Bl80UlnAko0TAROsCX7qQRKr9UDCcjJfBvE wDZ36voxQOu3oxe3HGvxFxIHwvdmhM0VLAgapBHU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390238AbfHHTsW (ORCPT ); Thu, 8 Aug 2019 15:48:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:56446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728025AbfHHTsW (ORCPT ); Thu, 8 Aug 2019 15:48:22 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 825AD21743; Thu, 8 Aug 2019 19:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565293701; bh=4WUS76RX+FiZef2BNrBwnS2eID3LAJlXHfM9bsTyhPQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=IJRA09PfOX3V5eyUEyDGjC/OBcbfWcmDQ0XQ7L9wIKQ6+RMXlYQT1VNCPahIjZiIi VCvxME+Pc3SgOsNZigL4EP3OhHEWfhzbRurqqROrMBmZP1n5IWGvAWwcX8gmwejK04 FyAGBCHl2mmJUkTNA8xOOdYNjTyzcQwixsPszDQg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Michael Turquette , Philippe Mathieu-Daud?? , Florian Fainelli , linux-kernel@vger.kernel.org, kbuild-all@01.org To: Jonas Gorski , Julia Lawall User-Agent: alot/0.8.1 Date: Thu, 08 Aug 2019 12:48:20 -0700 Message-Id: <20190808194821.825AD21743@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Julia Lawall (2019-08-08 09:10:53) > From: kbuild test robot >=20 > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_io= remap_resource for hw -> regs >=20 > Use devm_platform_ioremap_resource helper which wraps > platform_get_resource() and devm_ioremap_resource() together. >=20 > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci >=20 > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver") Is it fixing anything? As far as I can tell it's reducing lines of code with another function. > CC: Jonas Gorski > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall