From: Greg KH <gregkh@linuxfoundation.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: ard.biesheuvel@linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB
Date: Fri, 9 Aug 2019 14:56:49 +0200 [thread overview]
Message-ID: <20190809125649.GA2531@kroah.com> (raw)
In-Reply-To: <20190809102150.66896-1-yuehaibing@huawei.com>
On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote:
> USB_WUSB should depends on CONFIG_USB, otherwise building fails
>
> drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
> wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/wusbcore/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
> index 056c60b..a559d02 100644
> --- a/drivers/staging/wusbcore/Kconfig
> +++ b/drivers/staging/wusbcore/Kconfig
> @@ -4,7 +4,7 @@
> #
> config USB_WUSB
> tristate "Enable Wireless USB extensions"
> - depends on UWB
> + depends on UWB && USB
> select CRYPTO
> select CRYPTO_AES
> select CRYPTO_CCM
> --
> 2.7.4
Ah, good catch, sorry about that!
greg k-h
prev parent reply other threads:[~2019-08-09 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 10:21 [PATCH] staging: wusbcore: Fix build error without CONFIG_USB YueHaibing
2019-08-09 12:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809125649.GA2531@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox