From: Fabio Estevam <festevam@gmail.com>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, andrew.smirnov@gmail.com,
cphealy@gmail.com, l.stach@pengutronix.de,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: [PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds
Date: Sat, 10 Aug 2019 12:42:59 -0300 [thread overview]
Message-ID: <20190810154300.25950-1-festevam@gmail.com> (raw)
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Command to erase application firmware on RAVE SP takes longer than one
second (it takes ~3s). Bump command timeout duration to 5 seconds in
order to avoid bogus timeouts.
Cc: <stable@vger.kernel.org>
Fixes: 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor")
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/mfd/rave-sp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index 26c7b63e008a..546763d8a3e5 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -371,7 +371,7 @@ int rave_sp_exec(struct rave_sp *sp,
rave_sp_write(sp, data, data_size);
- if (!wait_for_completion_timeout(&reply.received, HZ)) {
+ if (!wait_for_completion_timeout(&reply.received, 5 * HZ)) {
dev_err(&sp->serdev->dev, "Command timeout\n");
ret = -ETIMEDOUT;
next reply other threads:[~2019-08-10 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 15:42 Fabio Estevam [this message]
2019-08-10 15:43 ` [PATCH 2/2] mfd: rave-sp: Add support for firmware update Fabio Estevam
2019-08-11 13:13 ` [PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810154300.25950-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox